Skip to content

v0.22.0 on Mac regression - 'browser not closing after test' is re-occurring #2860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jantonypdx opened this issue Sep 13, 2018 · 4 comments
Closed
Assignees
Labels
AREA: server OS: Mac STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: browser natives TYPE: bug The described behavior is considered as wrong (bug).
Milestone

Comments

@jantonypdx
Copy link

Are you requesting a feature or reporting a bug?

bug

What is the current behavior?

Looks like a regression of this issue: #2132

In v0.22.0 - after test completes, Chrome process remains open (in dock)

What is the expected behavior?

In v0.20.5 - after test completes, Chrome browser closes

How would you reproduce the current behavior (if this is a bug)?

Run test using Chrome:

npx testcafe chrome test.js

Provide the test code and the tested page URL (if applicable)

Tested page URL:
https://devexpress.github.io/testcafe/example
Test code

// From your github page: https://github.com/DevExpress/testcafe
import { Selector } from 'testcafe'; // first import testcafe selectors

fixture `Getting Started`// declare the fixture
    .page `https://devexpress.github.io/testcafe/example`;  // specify the start page

//then create a test and place your code there
test('My first test', async t => {
    await t
        .typeText('#developer-name', 'John Smith')
        .click('#submit-button')

        // Use the assertion to check if the actual header text is equal to the expected one
        .expect(Selector('#article-header').innerText).eql('Thank you, John Smith!');
});

Specify your

  • operating system: Mac Sierra 10.12.6
  • testcafe version: 0.22.0
  • node.js version: 10.9.0
@AndreyBelym AndreyBelym added the STATE: Need clarification An issue lacks information for further research. label Sep 13, 2018
@AndreyBelym
Copy link
Contributor

Hi @jantonypdx, I guess it's a regression of #2226. Please read my comment for more details. Could you please run ps -ef >ps-ef.log and ps aux >ps-aux.log after running TestCafe, and post the ps-ef.log and ps-aux.log files?

@jantonypdx
Copy link
Author

Here you go:
ps-ef.log
ps-aux.log

@AndreyBelym AndreyBelym added TYPE: bug The described behavior is considered as wrong (bug). SYSTEM: browser natives AREA: server OS: Mac and removed STATE: Need clarification An issue lacks information for further research. labels Sep 27, 2018
@AndreyBelym
Copy link
Contributor

Hi @jantonypdx, sorry for the late response. Judging by the differences in the log files, it's really the regressed #2226. I think we have to get rid of the ps-node module, because it works unreliably on macOS systems.

@AndreyBelym AndreyBelym added this to the Sprint #19 milestone Oct 2, 2018
@AndreyBelym AndreyBelym modified the milestones: Sprint #19, Sprint #20 Oct 15, 2018
@AlexKamaev AlexKamaev self-assigned this Oct 29, 2018
AlexKamaev added a commit to AlexKamaev/testcafe that referenced this issue Oct 29, 2018
AlexKamaev added a commit to AlexKamaev/testcafe that referenced this issue Oct 30, 2018
@AndreyBelym AndreyBelym modified the milestones: Sprint #20, Sprint #21 Oct 31, 2018
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or feature requests. For TestCafe API, usage and configuration inquiries, we recommend asking them on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this issue Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
AREA: server OS: Mac STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: browser natives TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Development

No branches or pull requests

3 participants