Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to switch to an invisible iframe #4558

Closed
helen-dikareva opened this issue Dec 9, 2019 · 2 comments · Fixed by #7020
Closed

Allow to switch to an invisible iframe #4558

helen-dikareva opened this issue Dec 9, 2019 · 2 comments · Fixed by #7020
Labels
AREA: client Support Center An issue created/received from the Support Center ticket. SYSTEM: automations TYPE: enhancement The accepted proposal for future implementation.
Milestone
Planned

Comments

@helen-dikareva
Copy link
Collaborator

helen-dikareva commented Dec 9, 2019 •
edited

Reasons:

  1. some sites use invisible iframes to perform some util logic (for example see a Studio issue)
  2. we have actions that don't check element's visiblity before execution (pressKey, navigateTo etc.)
  3. we have even one action with selector that doesn't check element's visibility - setFilesToUpload
  4. users use a hack to execute such switching, they assign 1px*1px size to an invisible iframe. So there is only 1px but our behavior is absolutely different in this case.

Test should fail during action execution for this iframe if the required element is invisible.
@helen-dikareva helen-dikareva added TYPE: enhancement The accepted proposal for future implementation. AREA: client SYSTEM: automations Support Center An issue created/received from the Support Center ticket. labels Dec 9, 2019
@helen-dikareva helen-dikareva added this to the Planned milestone Dec 9, 2019
@helen-dikareva helen-dikareva changed the title We should give a capability to switch to invisible iframe We should give a capability to switch to an invisible iframe Dec 9, 2019
@Dmitry-Ostashev
Copy link
Contributor

https://supportcenter.devexpress.com/internal/ticket/details/T1046549

@AndreyBelym AndreyBelym changed the title We should give a capability to switch to an invisible iframe Research if we should give a capability to switch to an invisible iframe May 6, 2022
@AndreyBelym AndreyBelym added TYPE: research and removed TYPE: enhancement The accepted proposal for future implementation. labels May 6, 2022
Artem-Babich added a commit to Artem-Babich/testcafe that referenced this issue May 10, 2022
@Artem-Babich
Allow switching to an invisible iframe(closes DevExpress#4558)
f3c89e2
@Artem-Babich Artem-Babich mentioned this issue May 10, 2022
Merged
@AndreyBelym AndreyBelym changed the title Research if we should give a capability to switch to an invisible iframe Allow to switch to an invisible iframe May 24, 2022
@AndreyBelym AndreyBelym added TYPE: enhancement The accepted proposal for future implementation. and removed TYPE: research labels May 24, 2022
AndreyBelym pushed a commit that referenced this issue May 31, 2022
@Artem-Babich
refactor: switching to an invisible iframe(closes #4558) (#7020)
70f753d 
* Allow switching to an invisible iframe(closes #4558)

* add display none check and fix tests

* add isIframeElement to proxyless

* increase driver connection timeout

* add note to timeout
@github-actions
Copy link

Release v1.20.0-alpha.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
AREA: client Support Center An issue created/received from the Support Center ticket. SYSTEM: automations TYPE: enhancement The accepted proposal for future implementation.
Projects
None yet
Milestone
Planned
Development

Successfully merging a pull request may close this issue.

Allow switching to an invisible iframe(closes #4558) Artem-Babich/testcafe
3 participants
@AndreyBelym @helen-dikareva @Dmitry-Ostashev