-
Notifications
You must be signed in to change notification settings - Fork 676
Click event triggered twice #5380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I changed the test code and was able to reproduce the issue: a click event on the zoom button (which appears only with a mobile version) is triggered twice. This test fails although it shouldn't: import { Selector } from 'testcafe';
const testCaseName = `Zoom`;
fixture(testCaseName).page('http://test-viewer.kristianhristov.com/test/A2-simple-with-zoom.html');
test("Zoom panel should be opened when clicked", async t => {
const zoomPanel = await Selector('.cylindo-zoom-imagery');
await t
.expect(zoomPanel.visible)
.notOk('Zoomed viewport should not be visible before click on zoom button');
await t.click(Selector('.threesixty-button'));
await t
.expect(zoomPanel.visible)
.ok('Zoomed viewport should be visible after click on zoom button');
}); It is possible to run the following command:
(or use the remote mode) Thank you for bringing this to our attention. We'll update this issue when we have any news. |
@wentwrong any ETA for this issue? This is really urgent for us and this is not the only event that is being triggered twice, some other clicks are being triggered multiple times too... |
Unfortunately, at the moment we cannot give any ETA for this bug. Once we have news to report, we will notify you here. |
Hi @LavrovArtem thanks for your quick reply. Do you think it is important to list you some other examples where I noticed the same behavior here? One more thing that I think is important to mention is that we have enabled touch and click events at the same time in case users have devices with touch screen and mouse. This is because we don't know which device will be used to execute the functionality, so, we have both listeners enabled. Internally we handle it with preventDefaults, stopPropagation and stopImmediatePropagation, etc. |
Hello,
At present, we have all the information we need to process this issue. If you encounter any other issues after the fix is published, please report them.
Thank you for the information. Our goal in this case is not to break the native behavior. |
To the team: |
Hi @AlexKamaev, do you have any update on this issue? |
Hello @Esteban26, There are no updates yet. |
thanks! |
Hi
I have a test case where we expected the zoom module to be opened when the user clicks on the zoom button. It works on mobile when I tap the button manually. The problem I'm facing is when I run the test on a real mobile device using the remote tool from test cafe. The zoom panel is opened and then closed, I checked the events and the button is getting clicked twice.
The double click does not happen on desktop devices, or when I click/tap it manually you can verify it at:
http://test-viewer.kristianhristov.com/test/A2-simple-with-zoom.html
(On desktop devices zoom button is not displayed, but zoom module opens when you click the viewport)
testcafe version: 1.8.5
node.js version: v10.13.0
command-line arguments: testcafe "remote" "-S" "-s" "artifacts/screenshots" "-p" "${USERAGENT}${FIXTURE}_${TEST}.png" "test/spec/complete/A1-*.spec.ts" "--app" "node test/serve.js" "--speed" "1" "--quarantine-mode" "--qr-code"
browser name and version: Chrome mobile 84.0.4147.105
platform and version: Huawei mate 20 lite
The text was updated successfully, but these errors were encountered: