Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigateTo action should be considered as a top window command #6113

Closed
helen-dikareva opened this issue Apr 5, 2021 · 3 comments
Closed
Labels
API MODIFICATION LEVEL: breaking changes AREA: client HAS WORKAROUND STATE: Stale An outdated issue that will be automatically closed by the Stale bot. SYSTEM: automations TYPE: enhancement The accepted proposal for future implementation.

Comments

@helen-dikareva
Copy link
Collaborator

This does not match the way browsers work.

What is your Test Scenario?

fixture `fixture`
    .page `http://test`;

test('t', async t => {
    await t
        .switchToIframe('iframe')
        .navigateTo('http://google.com');

//iframe's window will be redirected to a new url instead of the top window
})

What are you suggesting?

The isExecutableInTopWindowOnly method should return true for the navigateTo command

What alternatives have you considered?

Additional context

Based on Becci Watson feedback

@thelazurite-cell
Copy link

thelazurite-cell commented Apr 8, 2021

This would be a great addition. I have worked around it with this method:
#6085 (comment)

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Apr 8, 2021
@miherlosev miherlosev removed the STATE: Need response An issue that requires a response or attention from the team. label Apr 9, 2021
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had any activity for a long period. It will be closed and archived if no further activity occurs. However, we may return to this issue in the future. If it still affects you or you have any additional information regarding it, please leave a comment and we will keep it open.

@github-actions github-actions bot added the STATE: Stale An outdated issue that will be automatically closed by the Stale bot. label Apr 10, 2022
@github-actions
Copy link

We're closing this issue after a prolonged period of inactivity. If it still affects you, please add a comment to this issue with up-to-date information. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API MODIFICATION LEVEL: breaking changes AREA: client HAS WORKAROUND STATE: Stale An outdated issue that will be automatically closed by the Stale bot. SYSTEM: automations TYPE: enhancement The accepted proposal for future implementation.
Projects
None yet
Development

No branches or pull requests

3 participants