Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the 'skipped' flag to the reporter.reportTestStarted method to indicate that this test is skipped #7065

Closed
VasilyStrelyaev opened this issue Jun 1, 2022 · 1 comment · Fixed by #7105
Closed

Pass the 'skipped' flag to the reporter.reportTestStarted method to indicate that this test is skipped #7065

VasilyStrelyaev opened this issue Jun 1, 2022 · 1 comment · Fixed by #7105
Assignees
@Aleksey28
Labels
TYPE: enhancement The accepted proposal for future implementation.

Comments

@VasilyStrelyaev
Copy link
Collaborator

VasilyStrelyaev commented Jun 1, 2022 •
edited

What is your Scenario?

I am running tests with a custom reporter. I want to be able to calculate how many tests actually ran.

What are you suggesting?

Currently, the reporter.reportTestStarted method is called for tests that are skipped, for backward compatibility. I would like TestCafe to pass a skipped flag to this method to indicate if a test is actually started or skipped.

What alternatives have you considered?

Saving the list of skipped tests on report.reportTaskStarted but because of #7062, the report.reportTestStarted method is sometimes completed earlier than reportTaskStarted.

Additional context

No response
@VasilyStrelyaev VasilyStrelyaev added the TYPE: enhancement The accepted proposal for future implementation. label Jun 1, 2022
@Aleksey28 Aleksey28 self-assigned this Jun 22, 2022
@Aleksey28 Aleksey28 mentioned this issue Jun 22, 2022
Merged
2 tasks
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

Release v1.20.0-rc.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aleksey28 Aleksey28

Labels
TYPE: enhancement The accepted proposal for future implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: added the skipped option to the testStartInfo of the reportTestStart method Aleksey28/testcafe
2 participants
@VasilyStrelyaev @Aleksey28