Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression of video behaviour #7218

Closed
zoe-jobson-IL opened this issue Aug 4, 2022 · 2 comments · Fixed by #7268
Closed

regression of video behaviour #7218

zoe-jobson-IL opened this issue Aug 4, 2022 · 2 comments · Fixed by #7268
Assignees
Labels
SYSTEM: video recording An issue related to the video recording functionality. TYPE: bug The described behavior is considered as wrong (bug).

Comments

@zoe-jobson-IL
Copy link

What is your Scenario?

this is a continuance of #7189 we have tried 1.20.1-rc2 and while we are seeing more of the videos that we were in 1.20 we are still loosing the essential ends of videos

What is the Current behavior?

WHen 40 tests (run times from a few seconds to a couple of minutes) are run concurrently (3 or 4 at once) many loose the endings on the video recordings.

What is the Expected behavior?

all videos are complete (as in 1.18 and 1.19)

What is your public website URL? (or attach your complete example)

not relevant

What is your TestCafe test code?

irrelevant (I can provide zipped comparative videos if required)

Your complete configuration file

we have an extensive set of config.js files

Your complete test report

report irrelevant - tests pass correctly

Screenshots

No response

Steps to Reproduce

  1. gather a reasonably sized suite of tests which run for a variety of times, set up video recording, run against headless chrome/chromium
  2. run with concurrency of 3 or 4
  3. watch videos - ones from the middle onwards - especially longer running ones are cut short

TestCafe version

1.20.1-rc2

Node.js version

16.14.2

Command-line arguments

irrelevant - run by internal script

Browser name(s) and version(s)

Version 104.0.5112.81 (Official Build) (64-bit)

Platform(s) and version(s)

windows 11 (1.20 was also failing on alpine)

Other

#7189

@zoe-jobson-IL zoe-jobson-IL added the TYPE: bug The described behavior is considered as wrong (bug). label Aug 4, 2022
@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Aug 4, 2022
@miherlosev
Copy link
Collaborator

Hi @zoe-jobson-IL

Thank you for the shared information. I've reproduced the issue with the following example:

testcafe chrome test.js --videos --concurrency 4
import { ClientFunction, t } from 'testcafe';

fixture ('Fixture');

const updateContent = ClientFunction((testNumber, stageNumber) => {
    var h1 = document.createElement('h1');

    h1.textContent = 'Test ' + testNumber + ': ' + stageNumber;

    document.body.appendChild(h1);
});

async function testBody (testNumber) {
    await updateContent(testNumber, '1');
    await t.wait(1000 * testNumber);
    await updateContent(testNumber, '2');
    await t.wait(1000);
    await updateContent(testNumber, '3');
    await t.wait(1000);
}

test('test1', async t => {
    await testBody(1);
});

test('test2', async t => {
    await testBody(2);
});

test('test3', async t => {
    await testBody(3);
});

test('test4', async t => {
    await testBody(4);
});

test('test5', async t => {
    await testBody(5);
});

test('test6', async t => {
    await testBody(6);
});

test('test7', async t => {
    await testBody(7);
});

test('test8', async t => {
    await testBody(8);
});

test('test9', async t => {
    await testBody(9);
});

test('test10', async t => {
    await testBody(10);
});

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Aug 5, 2022
@miherlosev miherlosev self-assigned this Aug 5, 2022
@miherlosev miherlosev added the SYSTEM: video recording An issue related to the video recording functionality. label Aug 5, 2022
@miherlosev miherlosev removed their assignment Aug 8, 2022
@miherlosev miherlosev linked a pull request Sep 1, 2022 that will close this issue
miherlosev added a commit that referenced this issue Sep 2, 2022
* fix video recording in concurrency mode

* fix review

* renames
@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Release v2.0.1-alpha.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SYSTEM: video recording An issue related to the video recording functionality. TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants