Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Infinity width for non-TTY streams #6930

Conversation

PayBas
Copy link
Contributor

@PayBas PayBas commented Mar 17, 2022

Purpose

Fixes #5919

Approach

trivial

References

#5919

Pre-Merge TODO

  • Write tests for your proposed changes
  • Make sure that existing tests do not fail

I didn't find any tests that have coverage on get-viewport-width.ts, so I assumed that tests weren't necessary for this. If it makes you feel any better, it's trivially easy to test manually.

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Mar 17, 2022
@VasilyStrelyaev
Copy link
Collaborator

Thank you for your contribution! We will update this pull request once we complete our review.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Mar 18, 2022
@AndreyBelym
Copy link
Contributor

Thank you for your contribution. Don't you think that it would be better to just set the viewport width to Infinity if the output stream is not a TTY? This way you won't have to configure your environment variables to get decent reports in CI - since every CI system I know can scroll report output.

While we don't have unit tests for this module, I assume that it was not a decision. I would like to add some test at least for the new functionality.

@PayBas
Copy link
Contributor Author

PayBas commented Mar 19, 2022

@AndreyBelym that would be fine as well. Just let me know what you guys decide and I'll update it.

As for tests: I'm somewhat confused by the test setup here. I'm not a frontend developer, and it's been quite a while since I used any of this stuff. I'd have to familiarize myself with the test setup, and that might take quite a while.

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Mar 19, 2022
@Aleksey28
Copy link
Collaborator

Thank you for your contribution. We are ready to approve of your pull request. Please set Infinity if the output stream is not a TTY. We'll add tests ourselves.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Mar 21, 2022
@miherlosev miherlosev self-requested a review May 6, 2022 06:58
@miherlosev miherlosev temporarily deployed to authentication May 6, 2022 07:37 Inactive
@miherlosev miherlosev temporarily deployed to CI May 6, 2022 07:41 Inactive
@miherlosev miherlosev force-pushed the feature/5919-use-env-var-for-default-viewport-width-in-get-viewport-width-ts branch from 9d692c1 to 1b45c69 Compare May 10, 2022 10:38
@miherlosev miherlosev temporarily deployed to authentication May 10, 2022 10:38 Inactive
@miherlosev miherlosev temporarily deployed to CI May 10, 2022 10:48 Inactive
@miherlosev miherlosev temporarily deployed to authentication May 10, 2022 11:20 Inactive
@miherlosev miherlosev temporarily deployed to CI May 10, 2022 11:21 Inactive
@miherlosev miherlosev changed the title Use TC_DEFAULT_VIEWPORT_WIDTH env var to allow overriding of DEFAULT_VIEWPORT_WIDTH Use Infinity width for non-TTY streams May 13, 2022
@testcafe-build-bot testcafe-build-bot merged commit 5d6574a into DevExpress:master Jun 1, 2022
@github-actions
Copy link

Release v1.20.0-alpha.1 addresses this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DEFAULT_VIEWPORT_WIDTH too narrow for non tty gitlab runners
7 participants