New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Infinity width for non-TTY streams #6930
Use Infinity width for non-TTY streams #6930
Conversation
Thank you for your contribution! We will update this pull request once we complete our review. |
Thank you for your contribution. Don't you think that it would be better to just set the viewport width to While we don't have unit tests for this module, I assume that it was not a decision. I would like to add some test at least for the new functionality. |
@AndreyBelym that would be fine as well. Just let me know what you guys decide and I'll update it. As for tests: I'm somewhat confused by the test setup here. I'm not a frontend developer, and it's been quite a while since I used any of this stuff. I'd have to familiarize myself with the test setup, and that might take quite a while. |
Thank you for your contribution. We are ready to approve of your pull request. Please set |
…VIEWPORT_WIDTH in get-viewport-width.ts (5919)
9d692c1
to
1b45c69
Compare
Release v1.20.0-alpha.1 addresses this. |
Purpose
Fixes #5919
Approach
trivial
References
#5919
Pre-Merge TODO
I didn't find any tests that have coverage on
get-viewport-width.ts
, so I assumed that tests weren't necessary for this. If it makes you feel any better, it's trivially easy to test manually.