From 9990e8f7b50a21c1c394965e91fa90096dfcaa63 Mon Sep 17 00:00:00 2001 From: Bas van Erp Date: Thu, 17 Mar 2022 09:36:38 +0100 Subject: [PATCH 1/4] Use TC_DEFAULT_VIEWPORT_WIDTH env var to allow overriding of DEFAULT_VIEWPORT_WIDTH in get-viewport-width.ts (5919) --- src/utils/get-viewport-width.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/get-viewport-width.ts b/src/utils/get-viewport-width.ts index 7e32146396..cc49577db6 100644 --- a/src/utils/get-viewport-width.ts +++ b/src/utils/get-viewport-width.ts @@ -1,7 +1,7 @@ import tty, { WriteStream } from 'tty'; import { Stream } from 'stream'; -const DEFAULT_VIEWPORT_WIDTH = 78; +const DEFAULT_VIEWPORT_WIDTH = parseInt(process.env.TC_DEFAULT_VIEWPORT_WIDTH as string, 10) || 78; export default function (outStream: Stream): number { if (outStream === process.stdout && tty.isatty(1)) { From 0a9dc24927073efddb13353da52f3d2d9696a81f Mon Sep 17 00:00:00 2001 From: MargaritaLoseva Date: Fri, 6 May 2022 11:37:26 +0400 Subject: [PATCH 2/4] use infinity value for non-tty streams --- src/utils/get-viewport-width.ts | 6 +++--- test/server/util-test.js | 8 +++++++- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/src/utils/get-viewport-width.ts b/src/utils/get-viewport-width.ts index cc49577db6..4a97a83ae0 100644 --- a/src/utils/get-viewport-width.ts +++ b/src/utils/get-viewport-width.ts @@ -1,7 +1,7 @@ import tty, { WriteStream } from 'tty'; import { Stream } from 'stream'; -const DEFAULT_VIEWPORT_WIDTH = parseInt(process.env.TC_DEFAULT_VIEWPORT_WIDTH as string, 10) || 78; +const DEFAULT_VIEWPORT_WIDTH_TTY = 78; export default function (outStream: Stream): number { if (outStream === process.stdout && tty.isatty(1)) { @@ -9,8 +9,8 @@ export default function (outStream: Stream): number { process.stdout.getWindowSize()[0] : (tty as unknown as WriteStream).getWindowSize()[1]; - return Math.max(detectedViewportWidth, DEFAULT_VIEWPORT_WIDTH); + return Math.max(detectedViewportWidth, DEFAULT_VIEWPORT_WIDTH_TTY); } - return DEFAULT_VIEWPORT_WIDTH; + return Infinity; } diff --git a/test/server/util-test.js b/test/server/util-test.js index 9d75651be1..3470dbf9b5 100644 --- a/test/server/util-test.js +++ b/test/server/util-test.js @@ -23,7 +23,7 @@ const createTempProfile = require('../../lib/browser/provider/bui const parseUserAgent = require('../../lib/utils/parse-user-agent'); const diff = require('../../lib/utils/diff'); const { generateScreenshotMark } = require('../../lib/screenshots/utils'); - +const getViewPortWidth = require('../../lib/utils/get-viewport-width'); const { buildChromeArgs, IN_DOCKER_FLAGS, @@ -615,4 +615,10 @@ describe('Utils', () => { for (const markPixel of markSeed) expect(markPixel === 0 || markPixel === 255).is.true; }); + + it('getViewPortWidth', () => { + const nonTTYStreamMock = {}; + + expect(getViewPortWidth(nonTTYStreamMock)).eql(Infinity); + }); }); From 1b45c699ae9b01ea42fc5bde4d786ff10a9456b6 Mon Sep 17 00:00:00 2001 From: miherlosev Date: Tue, 10 May 2022 01:43:11 +0400 Subject: [PATCH 3/4] update etalons --- test/server/data/execute-async-expression/runtime-error | 4 +--- test/server/data/execute-async-expression/test-run-error | 3 +-- .../expected-legacy-test-run-errors/empty-first-argument | 4 +--- .../incorrect-wait-for-action-event-argument | 3 +-- .../invisible-action-element | 3 +-- .../multiple-iframe-argument | 3 +-- .../store-dom-node-or-jquery-object | 3 +-- .../action-additional-element-not-found-error | 2 +- ...ction-additional-selector-matches-wrong-node-type-error | 3 +-- .../expected-test-run-errors/action-boolean-argument-error | 3 +-- .../expected-test-run-errors/action-boolean-option-error | 3 +-- .../expected-test-run-errors/action-cookie-argument-error | 3 +-- .../action-element-non-content-editable-error | 4 +--- .../action-element-non-editable-error | 3 +-- .../action-element-not-found-error | 2 +- .../action-invalid-scroll-target-error | 3 +-- .../action-non-empty-string-array-argument-error | 3 +-- .../expected-test-run-errors/action-options-type-error | 3 +-- .../action-root-container-not-found-error | 4 +--- .../action-selector-matches-wrong-node-type-error | 3 +-- .../expected-test-run-errors/action-speed-option-error | 3 +-- .../action-string-array-element-error | 3 +-- .../action-unsupported-device-type-error | 4 +--- .../assertion-executable-argument-error | 3 +-- .../assertion-unawaited-promise-error | 3 +-- .../cannot-close-window-without-parent-error | 4 +--- ...not-obtain-info-for-element-specified-by-selector-error | 5 ++--- .../client-function-execution-interruption-error | 3 +-- .../dom-node-client-function-result-error | 3 +-- .../external-assertion-library-errors/builtin/equal/array | 3 +-- .../external-assertion-library-errors/builtin/equal/buffer | 3 +-- .../external-assertion-library-errors/builtin/equal/object | 3 +-- .../invalid-element-screenshot-dimensions-error | 3 +-- .../expected-test-run-errors/invalid-selector-result-error | 4 +--- .../data/expected-test-run-errors/missing-await-error | 4 +--- .../multiple-windows-mode-is-disabled-error | 3 +-- ...e-windows-mode-is-not-available-in-remote-browser-error | 4 +--- .../native-dialog-not-handled-error | 4 +--- test/server/data/expected-test-run-errors/page-load-error | 7 ++----- .../expected-test-run-errors/parent-window-not-found-error | 3 +-- .../previous-window-not-found-error | 3 +-- .../set-native-dialog-handler-code-wrong-type-error | 3 +-- ...t-error-in-custom-client-script-code-loaded-from-module | 3 +-- .../uncaught-error-in-native-dialog-handler | 3 +-- .../expected-test-run-errors/uncaught-js-error-on-page | 6 ++---- .../window-dimensions-overflow-error | 3 +-- 46 files changed, 49 insertions(+), 106 deletions(-) diff --git a/test/server/data/execute-async-expression/runtime-error b/test/server/data/execute-async-expression/runtime-error index 4cc9f6c414..3538d93459 100644 --- a/test/server/data/execute-async-expression/runtime-error +++ b/test/server/data/execute-async-expression/runtime-error @@ -2,9 +2,7 @@ An unhandled error occurred in the custom script: Cannot prepare tests due to the following error: -Cannot initialize a Selector because Selector is undefined, and not one of -the following: a CSS selector string, a Selector object, a node snapshot, a -function, or a Promise returned by a Selector. +Cannot initialize a Selector because Selector is undefined, and not one of the following: a CSS selector string, a Selector object, a node snapshot, a function, or a Promise returned by a Selector. const s = Selector(); diff --git a/test/server/data/execute-async-expression/test-run-error b/test/server/data/execute-async-expression/test-run-error index 7037f9cd2d..73cc312037 100644 --- a/test/server/data/execute-async-expression/test-run-error +++ b/test/server/data/execute-async-expression/test-run-error @@ -1,7 +1,6 @@ An unhandled error occurred in the custom script: -The "timeout" argument is expected to be a positive integer, but it was -string. +The "timeout" argument is expected to be a positive integer, but it was string. Browser: Chrome 15.0.874.120 / macOS 10.15 diff --git a/test/server/data/expected-legacy-test-run-errors/empty-first-argument b/test/server/data/expected-legacy-test-run-errors/empty-first-argument index 4551700de1..137dbaa45f 100644 --- a/test/server/data/expected-legacy-test-run-errors/empty-first-argument +++ b/test/server/data/expected-legacy-test-run-errors/empty-first-argument @@ -1,8 +1,6 @@ Error at step "Step with ": A target element of the testAction action has not been found in the DOM tree. -If this element should be created after animation or a time-consuming -operation is finished, use the waitFor action (available for use in code) to -pause test execution until this element appears. +If this element should be created after animation or a time-consuming operation is finished, use the waitFor action (available for use in code) to pause test execution until this element appears. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-legacy-test-run-errors/incorrect-wait-for-action-event-argument b/test/server/data/expected-legacy-test-run-errors/incorrect-wait-for-action-event-argument index 6caa94af30..bcf4e33595 100644 --- a/test/server/data/expected-legacy-test-run-errors/incorrect-wait-for-action-event-argument +++ b/test/server/data/expected-legacy-test-run-errors/incorrect-wait-for-action-event-argument @@ -1,6 +1,5 @@ Error at step "Step with ": -waitFor action's first parameter should be a function, a CSS selector or an -array of CSS selectors. +waitFor action's first parameter should be a function, a CSS selector or an array of CSS selectors. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-legacy-test-run-errors/invisible-action-element b/test/server/data/expected-legacy-test-run-errors/invisible-action-element index ac1cd9e795..d509950a33 100644 --- a/test/server/data/expected-legacy-test-run-errors/invisible-action-element +++ b/test/server/data/expected-legacy-test-run-errors/invisible-action-element @@ -1,7 +1,6 @@ Error at step "Step with ": A target element of the test-action action is not visible. -If this element should appear when you are hovering over another element, -make sure that you properly recorded the hover action. +If this element should appear when you are hovering over another element, make sure that you properly recorded the hover action. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-legacy-test-run-errors/multiple-iframe-argument b/test/server/data/expected-legacy-test-run-errors/multiple-iframe-argument index dd4882fd75..f4eaec7bdf 100644 --- a/test/server/data/expected-legacy-test-run-errors/multiple-iframe-argument +++ b/test/server/data/expected-legacy-test-run-errors/multiple-iframe-argument @@ -1,6 +1,5 @@ Error at step "Step with ": -The selector within the inIFrame function returns more than one iframe -element. +The selector within the inIFrame function returns more than one iframe element. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-legacy-test-run-errors/store-dom-node-or-jquery-object b/test/server/data/expected-legacy-test-run-errors/store-dom-node-or-jquery-object index 4a3e897570..feb1705987 100644 --- a/test/server/data/expected-legacy-test-run-errors/store-dom-node-or-jquery-object +++ b/test/server/data/expected-legacy-test-run-errors/store-dom-node-or-jquery-object @@ -1,6 +1,5 @@ Error at step "Step with ": -It is not allowed to share the DOM element, jQuery object or a function -between test steps via "this" object. +It is not allowed to share the DOM element, jQuery object or a function between test steps via "this" object. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-additional-element-not-found-error b/test/server/data/expected-test-run-errors/action-additional-element-not-found-error index ba7007da74..21c48359f4 100644 --- a/test/server/data/expected-test-run-errors/action-additional-element-not-found-error +++ b/test/server/data/expected-test-run-errors/action-additional-element-not-found-error @@ -1,6 +1,6 @@ The specified "startSelector" does not match any element in the DOM tree. -  | Lorem ipsum dolor sit amet, consectetur adipiscing el...) +  | Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua  > | one   | two   | three diff --git a/test/server/data/expected-test-run-errors/action-additional-selector-matches-wrong-node-type-error b/test/server/data/expected-test-run-errors/action-additional-selector-matches-wrong-node-type-error index 2e200a3f96..f8de313003 100644 --- a/test/server/data/expected-test-run-errors/action-additional-selector-matches-wrong-node-type-error +++ b/test/server/data/expected-test-run-errors/action-additional-selector-matches-wrong-node-type-error @@ -1,5 +1,4 @@ -The specified "startSelector" is expected to match a DOM element, but it -matches a text node. +The specified "startSelector" is expected to match a DOM element, but it matches a text node. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-boolean-argument-error b/test/server/data/expected-test-run-errors/action-boolean-argument-error index 6bad17a85e..b332db624a 100644 --- a/test/server/data/expected-test-run-errors/action-boolean-argument-error +++ b/test/server/data/expected-test-run-errors/action-boolean-argument-error @@ -1,5 +1,4 @@ -The "isAsyncExpression" argument is expected to be a boolean value, but it -was object. +The "isAsyncExpression" argument is expected to be a boolean value, but it was object. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-boolean-option-error b/test/server/data/expected-test-run-errors/action-boolean-option-error index dcc879a859..1860a952ce 100644 --- a/test/server/data/expected-test-run-errors/action-boolean-option-error +++ b/test/server/data/expected-test-run-errors/action-boolean-option-error @@ -1,5 +1,4 @@ -The "modifier.ctrl" option is expected to be a boolean value, but it was -object. +The "modifier.ctrl" option is expected to be a boolean value, but it was object. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-cookie-argument-error b/test/server/data/expected-test-run-errors/action-cookie-argument-error index b81be9a7be..7f13195943 100644 --- a/test/server/data/expected-test-run-errors/action-cookie-argument-error +++ b/test/server/data/expected-test-run-errors/action-cookie-argument-error @@ -1,5 +1,4 @@ -The value of the "cookies" argument does not belong to an acceptable data -type: Object, String, or Array of objects or strings. +The value of the "cookies" argument does not belong to an acceptable data type: Object, String, or Array of objects or strings. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-element-non-content-editable-error b/test/server/data/expected-test-run-errors/action-element-non-content-editable-error index f20b22ad11..c4a4107c6b 100644 --- a/test/server/data/expected-test-run-errors/action-element-non-content-editable-error +++ b/test/server/data/expected-test-run-errors/action-element-non-content-editable-error @@ -1,6 +1,4 @@ -The element that matches the specified "startSelector" is expected to have -the contentEditable attribute enabled or the entire document should be in -design mode. +The element that matches the specified "startSelector" is expected to have the contentEditable attribute enabled or the entire document should be in design mode. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-element-non-editable-error b/test/server/data/expected-test-run-errors/action-element-non-editable-error index b526383f1a..e085d4328b 100644 --- a/test/server/data/expected-test-run-errors/action-element-non-editable-error +++ b/test/server/data/expected-test-run-errors/action-element-non-editable-error @@ -1,5 +1,4 @@ -The action element is expected to be editable (an input, textarea or element -with the contentEditable attribute). +The action element is expected to be editable (an input, textarea or element with the contentEditable attribute). Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-element-not-found-error b/test/server/data/expected-test-run-errors/action-element-not-found-error index 4072c4d70d..678220b858 100644 --- a/test/server/data/expected-test-run-errors/action-element-not-found-error +++ b/test/server/data/expected-test-run-errors/action-element-not-found-error @@ -1,6 +1,6 @@ The specified selector does not match any element in the DOM tree. -  | Lorem ipsum dolor sit amet, consectetur adipiscing el...) +  | Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua  > | one   | two   | three diff --git a/test/server/data/expected-test-run-errors/action-invalid-scroll-target-error b/test/server/data/expected-test-run-errors/action-invalid-scroll-target-error index d1a93c269b..3330ac353f 100644 --- a/test/server/data/expected-test-run-errors/action-invalid-scroll-target-error +++ b/test/server/data/expected-test-run-errors/action-invalid-scroll-target-error @@ -1,5 +1,4 @@ -Unable to scroll to the specified point because a point with the specified -scrollTargetX property is not located inside the element's cropping region. +Unable to scroll to the specified point because a point with the specified scrollTargetX property is not located inside the element's cropping region. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-non-empty-string-array-argument-error b/test/server/data/expected-test-run-errors/action-non-empty-string-array-argument-error index 555f802cff..ba5acda70e 100644 --- a/test/server/data/expected-test-run-errors/action-non-empty-string-array-argument-error +++ b/test/server/data/expected-test-run-errors/action-non-empty-string-array-argument-error @@ -1,5 +1,4 @@ -The "array" argument is expected to be a non-empty string or a string array, -but it was null. +The "array" argument is expected to be a non-empty string or a string array, but it was null. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-options-type-error b/test/server/data/expected-test-run-errors/action-options-type-error index 86a2e10ce4..8933189227 100644 --- a/test/server/data/expected-test-run-errors/action-options-type-error +++ b/test/server/data/expected-test-run-errors/action-options-type-error @@ -1,5 +1,4 @@ -Action options is expected to be an object, null or undefined but it was -number. +Action options is expected to be an object, null or undefined but it was number. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-root-container-not-found-error b/test/server/data/expected-test-run-errors/action-root-container-not-found-error index 44fa6ebf7c..8051187353 100644 --- a/test/server/data/expected-test-run-errors/action-root-container-not-found-error +++ b/test/server/data/expected-test-run-errors/action-root-container-not-found-error @@ -1,6 +1,4 @@ -Content between the action elements cannot be selected because the root -container for the selection range cannot be found, i.e. these elements do not -have a common ancestor with the contentEditable attribute. +Content between the action elements cannot be selected because the root container for the selection range cannot be found, i.e. these elements do not have a common ancestor with the contentEditable attribute. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-selector-matches-wrong-node-type-error b/test/server/data/expected-test-run-errors/action-selector-matches-wrong-node-type-error index 28388c6c4f..76c0523471 100644 --- a/test/server/data/expected-test-run-errors/action-selector-matches-wrong-node-type-error +++ b/test/server/data/expected-test-run-errors/action-selector-matches-wrong-node-type-error @@ -1,5 +1,4 @@ -The specified selector is expected to match a DOM element, but it matches a -text node. +The specified selector is expected to match a DOM element, but it matches a text node. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-speed-option-error b/test/server/data/expected-test-run-errors/action-speed-option-error index 57679f1128..571754fe5d 100644 --- a/test/server/data/expected-test-run-errors/action-speed-option-error +++ b/test/server/data/expected-test-run-errors/action-speed-option-error @@ -1,5 +1,4 @@ -The "speed" option is expected to be a number between 0.01 and 1, but it was -object. +The "speed" option is expected to be a number between 0.01 and 1, but it was object. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-string-array-element-error b/test/server/data/expected-test-run-errors/action-string-array-element-error index 08b03d175d..998475ded9 100644 --- a/test/server/data/expected-test-run-errors/action-string-array-element-error +++ b/test/server/data/expected-test-run-errors/action-string-array-element-error @@ -1,5 +1,4 @@ -Elements of the "array" argument are expected to be non-empty strings, but -the element at index 1 was number. +Elements of the "array" argument are expected to be non-empty strings, but the element at index 1 was number. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-unsupported-device-type-error b/test/server/data/expected-test-run-errors/action-unsupported-device-type-error index e4ac5d5bdb..37118f0f2d 100644 --- a/test/server/data/expected-test-run-errors/action-unsupported-device-type-error +++ b/test/server/data/expected-test-run-errors/action-unsupported-device-type-error @@ -1,6 +1,4 @@ -The "device" argument specifies an unsupported "iPhone 555" device. For a -list of supported devices, refer to -"https://github.com/DevExpress/device-specs/blob/master/viewport-sizes.json". +The "device" argument specifies an unsupported "iPhone 555" device. For a list of supported devices, refer to "https://github.com/DevExpress/device-specs/blob/master/viewport-sizes.json". Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/assertion-executable-argument-error b/test/server/data/expected-test-run-errors/assertion-executable-argument-error index 5837fb7800..66578a159e 100644 --- a/test/server/data/expected-test-run-errors/assertion-executable-argument-error +++ b/test/server/data/expected-test-run-errors/assertion-executable-argument-error @@ -1,5 +1,4 @@ -Cannot evaluate the "1 + temp" expression in the "actual" parameter because -of the following error: +Cannot evaluate the "1 + temp" expression in the "actual" parameter because of the following error: Unexpected identifier diff --git a/test/server/data/expected-test-run-errors/assertion-unawaited-promise-error b/test/server/data/expected-test-run-errors/assertion-unawaited-promise-error index 3334a56d2a..db0977ae34 100644 --- a/test/server/data/expected-test-run-errors/assertion-unawaited-promise-error +++ b/test/server/data/expected-test-run-errors/assertion-unawaited-promise-error @@ -1,5 +1,4 @@ -Attempted to run assertions on a Promise object. Did you forget to await it? -If not, pass "{ allowUnawaitedPromise: true }" to the assertion options. +Attempted to run assertions on a Promise object. Did you forget to await it? If not, pass "{ allowUnawaitedPromise: true }" to the assertion options. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/cannot-close-window-without-parent-error b/test/server/data/expected-test-run-errors/cannot-close-window-without-parent-error index 5bfbeb0576..9cf2c61f92 100644 --- a/test/server/data/expected-test-run-errors/cannot-close-window-without-parent-error +++ b/test/server/data/expected-test-run-errors/cannot-close-window-without-parent-error @@ -1,6 +1,4 @@ -Cannot close the window because it does not have a parent. The parent window -was closed or you are attempting to close the root browser window where tests -were launched. +Cannot close the window because it does not have a parent. The parent window was closed or you are attempting to close the root browser window where tests were launched. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/cannot-obtain-info-for-element-specified-by-selector-error b/test/server/data/expected-test-run-errors/cannot-obtain-info-for-element-specified-by-selector-error index a8556ee792..12f8cce0c4 100644 --- a/test/server/data/expected-test-run-errors/cannot-obtain-info-for-element-specified-by-selector-error +++ b/test/server/data/expected-test-run-errors/cannot-obtain-info-for-element-specified-by-selector-error @@ -1,7 +1,6 @@ -Cannot obtain information about the node because the specified selector does -not match any node in the DOM tree. +Cannot obtain information about the node because the specified selector does not match any node in the DOM tree. -  | Lorem ipsum dolor sit amet, consectetur adipiscing el...) +  | Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua  > | one   | two   | three diff --git a/test/server/data/expected-test-run-errors/client-function-execution-interruption-error b/test/server/data/expected-test-run-errors/client-function-execution-interruption-error index ab0be3b8b3..c94061cbbf 100644 --- a/test/server/data/expected-test-run-errors/client-function-execution-interruption-error +++ b/test/server/data/expected-test-run-errors/client-function-execution-interruption-error @@ -1,5 +1,4 @@ -eval execution was interrupted by page unload. This problem may appear if you -trigger page navigation from eval code. +eval execution was interrupted by page unload. This problem may appear if you trigger page navigation from eval code. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/dom-node-client-function-result-error b/test/server/data/expected-test-run-errors/dom-node-client-function-result-error index ec039b3bdb..a4efd9abfa 100644 --- a/test/server/data/expected-test-run-errors/dom-node-client-function-result-error +++ b/test/server/data/expected-test-run-errors/dom-node-client-function-result-error @@ -1,5 +1,4 @@ -ClientFunction cannot return DOM elements. Use Selector functions for this -purpose. +ClientFunction cannot return DOM elements. Use Selector functions for this purpose. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/external-assertion-library-errors/builtin/equal/array b/test/server/data/expected-test-run-errors/external-assertion-library-errors/builtin/equal/array index b4cc046de3..465995e6ae 100644 --- a/test/server/data/expected-test-run-errors/external-assertion-library-errors/builtin/equal/array +++ b/test/server/data/expected-test-run-errors/external-assertion-library-errors/builtin/equal/array @@ -1,5 +1,4 @@ -AssertionError: expected [ 1, 2, 3, [ 4, 5 ], 6 ] to deeply equal [ 1, 4, 2, -3, [ 5, 6, [ 7 ] ] ] +AssertionError: expected [ 1, 2, 3, [ 4, 5 ], 6 ] to deeply equal [ 1, 4, 2, 3, [ 5, 6, [ 7 ] ] ] + expected - actual diff --git a/test/server/data/expected-test-run-errors/external-assertion-library-errors/builtin/equal/buffer b/test/server/data/expected-test-run-errors/external-assertion-library-errors/builtin/equal/buffer index e1d9701f2e..da683edb18 100644 --- a/test/server/data/expected-test-run-errors/external-assertion-library-errors/builtin/equal/buffer +++ b/test/server/data/expected-test-run-errors/external-assertion-library-errors/builtin/equal/buffer @@ -1,5 +1,4 @@ -AssertionError: expected to deeply equal +AssertionError: expected to deeply equal + expected - actual diff --git a/test/server/data/expected-test-run-errors/external-assertion-library-errors/builtin/equal/object b/test/server/data/expected-test-run-errors/external-assertion-library-errors/builtin/equal/object index 5c1b695771..baba0c61e2 100644 --- a/test/server/data/expected-test-run-errors/external-assertion-library-errors/builtin/equal/object +++ b/test/server/data/expected-test-run-errors/external-assertion-library-errors/builtin/equal/object @@ -1,5 +1,4 @@ -AssertionError: expected { Object (first) } to deeply equal { Object (first) -} +AssertionError: expected { Object (first) } to deeply equal { Object (first) } + expected - actual diff --git a/test/server/data/expected-test-run-errors/invalid-element-screenshot-dimensions-error b/test/server/data/expected-test-run-errors/invalid-element-screenshot-dimensions-error index f0cc28c9a6..a35a1604a1 100644 --- a/test/server/data/expected-test-run-errors/invalid-element-screenshot-dimensions-error +++ b/test/server/data/expected-test-run-errors/invalid-element-screenshot-dimensions-error @@ -1,5 +1,4 @@ -Unable to capture an element image because the resulting image width is zero -or negative. +Unable to capture an element image because the resulting image width is zero or negative. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/invalid-selector-result-error b/test/server/data/expected-test-run-errors/invalid-selector-result-error index 2f15764070..e4998899b7 100644 --- a/test/server/data/expected-test-run-errors/invalid-selector-result-error +++ b/test/server/data/expected-test-run-errors/invalid-selector-result-error @@ -1,6 +1,4 @@ -Function that specifies a selector can only return a DOM node, an array of -nodes, NodeList, HTMLCollection, null or undefined. Use ClientFunction to -return other values. +Function that specifies a selector can only return a DOM node, an array of nodes, NodeList, HTMLCollection, null or undefined. Use ClientFunction to return other values. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/missing-await-error b/test/server/data/expected-test-run-errors/missing-await-error index 62f84a828c..1affd8f817 100644 --- a/test/server/data/expected-test-run-errors/missing-await-error +++ b/test/server/data/expected-test-run-errors/missing-await-error @@ -1,6 +1,4 @@ -A call to an async function is not awaited. Use the "await" keyword before -actions, assertions or chains of them to ensure that they run in the right -sequence. +A call to an async function is not awaited. Use the "await" keyword before actions, assertions or chains of them to ensure that they run in the right sequence. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/multiple-windows-mode-is-disabled-error b/test/server/data/expected-test-run-errors/multiple-windows-mode-is-disabled-error index c0b9d2052d..4e16ab4083 100644 --- a/test/server/data/expected-test-run-errors/multiple-windows-mode-is-disabled-error +++ b/test/server/data/expected-test-run-errors/multiple-windows-mode-is-disabled-error @@ -1,5 +1,4 @@ -Multi-window mode is disabled. To use the "openWindow" method, remove the -"disableMultipleWindows" option. +Multi-window mode is disabled. To use the "openWindow" method, remove the "disableMultipleWindows" option. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/multiple-windows-mode-is-not-available-in-remote-browser-error b/test/server/data/expected-test-run-errors/multiple-windows-mode-is-not-available-in-remote-browser-error index 1a95211d81..a8a009c6e2 100644 --- a/test/server/data/expected-test-run-errors/multiple-windows-mode-is-not-available-in-remote-browser-error +++ b/test/server/data/expected-test-run-errors/multiple-windows-mode-is-not-available-in-remote-browser-error @@ -1,6 +1,4 @@ -Multi-window mode is supported only in locally-installed Chrome, Chromium, -Edge 84+ and Firefox. Run tests in these browsers to use the "openWindow" -method. +Multi-window mode is supported only in locally-installed Chrome, Chromium, Edge 84+ and Firefox. Run tests in these browsers to use the "openWindow" method. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/native-dialog-not-handled-error b/test/server/data/expected-test-run-errors/native-dialog-not-handled-error index 605fe735b8..fde3d1a5f1 100644 --- a/test/server/data/expected-test-run-errors/native-dialog-not-handled-error +++ b/test/server/data/expected-test-run-errors/native-dialog-not-handled-error @@ -1,6 +1,4 @@ -A native alert dialog was invoked on page "http://example.org", but no -handler was set for it. Use the "setNativeDialogHandler" function to -introduce a handler function for native dialogs. +A native alert dialog was invoked on page "http://example.org", but no handler was set for it. Use the "setNativeDialogHandler" function to introduce a handler function for native dialogs. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/page-load-error b/test/server/data/expected-test-run-errors/page-load-error index 4b0543a4c1..98d4b734e3 100644 --- a/test/server/data/expected-test-run-errors/page-load-error +++ b/test/server/data/expected-test-run-errors/page-load-error @@ -1,9 +1,6 @@ Failed to load the page at "http://some-url.example.com". -Increase the value of the "pageRequestTimeout" variable, enable the -"retryTestPages" option, or use quarantine mode to perform additional -attempts to execute this test. -You can find troubleshooting information for this issue at -"https://go.devexpress.com/TestCafe_FAQ_ARequestHasFailed.aspx". +Increase the value of the "pageRequestTimeout" variable, enable the "retryTestPages" option, or use quarantine mode to perform additional attempts to execute this test. +You can find troubleshooting information for this issue at "https://go.devexpress.com/TestCafe_FAQ_ARequestHasFailed.aspx". Error details: Failed to find a DNS-record for the resource diff --git a/test/server/data/expected-test-run-errors/parent-window-not-found-error b/test/server/data/expected-test-run-errors/parent-window-not-found-error index 370afa4f21..c5b79f1e99 100644 --- a/test/server/data/expected-test-run-errors/parent-window-not-found-error +++ b/test/server/data/expected-test-run-errors/parent-window-not-found-error @@ -1,5 +1,4 @@ -Cannot find the parent window. Make sure that the tested window was opened -from another window. +Cannot find the parent window. Make sure that the tested window was opened from another window. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/previous-window-not-found-error b/test/server/data/expected-test-run-errors/previous-window-not-found-error index 3b12e58577..76c35e892e 100644 --- a/test/server/data/expected-test-run-errors/previous-window-not-found-error +++ b/test/server/data/expected-test-run-errors/previous-window-not-found-error @@ -1,5 +1,4 @@ -Cannot find the previous window. Make sure that the previous window is -opened. +Cannot find the previous window. Make sure that the previous window is opened. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/set-native-dialog-handler-code-wrong-type-error b/test/server/data/expected-test-run-errors/set-native-dialog-handler-code-wrong-type-error index f305f09b01..fed9658e69 100644 --- a/test/server/data/expected-test-run-errors/set-native-dialog-handler-code-wrong-type-error +++ b/test/server/data/expected-test-run-errors/set-native-dialog-handler-code-wrong-type-error @@ -1,5 +1,4 @@ -The native dialog handler is expected to be a function, ClientFunction or -null, but it was number. +The native dialog handler is expected to be a function, ClientFunction or null, but it was number. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/uncaught-error-in-custom-client-script-code-loaded-from-module b/test/server/data/expected-test-run-errors/uncaught-error-in-custom-client-script-code-loaded-from-module index 80f4edadb3..f4667499e4 100644 --- a/test/server/data/expected-test-run-errors/uncaught-error-in-custom-client-script-code-loaded-from-module +++ b/test/server/data/expected-test-run-errors/uncaught-error-in-custom-client-script-code-loaded-from-module @@ -1,5 +1,4 @@ -An error occurred in the 'test-module' module injected into the tested page. -Make sure that this module can be executed in the browser environment. +An error occurred in the 'test-module' module injected into the tested page. Make sure that this module can be executed in the browser environment. Error details: TypeError: Cannot read property "prop" of undefined diff --git a/test/server/data/expected-test-run-errors/uncaught-error-in-native-dialog-handler b/test/server/data/expected-test-run-errors/uncaught-error-in-native-dialog-handler index 919f202c98..72e766442c 100644 --- a/test/server/data/expected-test-run-errors/uncaught-error-in-native-dialog-handler +++ b/test/server/data/expected-test-run-errors/uncaught-error-in-native-dialog-handler @@ -1,5 +1,4 @@ -An error occurred in the native dialog handler called for a native alert -dialog on page "http://example.org": +An error occurred in the native dialog handler called for a native alert dialog on page "http://example.org": error message diff --git a/test/server/data/expected-test-run-errors/uncaught-js-error-on-page b/test/server/data/expected-test-run-errors/uncaught-js-error-on-page index 1e30375ad6..38f32237cd 100644 --- a/test/server/data/expected-test-run-errors/uncaught-js-error-on-page +++ b/test/server/data/expected-test-run-errors/uncaught-js-error-on-page @@ -1,9 +1,7 @@ A JavaScript error occurred on "http://example.org". Repeat test actions in the browser and check the console for errors. -To ignore client-side JavaScript errors, enable the "--skip-js-errors" CLI -option, or set the "skipJsErrors" configuration file property to "true". -If the website only throws this error when you test it with TestCafe, please -create a new issue at: +To ignore client-side JavaScript errors, enable the "--skip-js-errors" CLI option, or set the "skipJsErrors" configuration file property to "true". +If the website only throws this error when you test it with TestCafe, please create a new issue at: "https://github.com/DevExpress/testcafe/issues/new?template=bug-report.md". JavaScript error details: diff --git a/test/server/data/expected-test-run-errors/window-dimensions-overflow-error b/test/server/data/expected-test-run-errors/window-dimensions-overflow-error index f8ab97b87b..67c6570134 100644 --- a/test/server/data/expected-test-run-errors/window-dimensions-overflow-error +++ b/test/server/data/expected-test-run-errors/window-dimensions-overflow-error @@ -1,5 +1,4 @@ -Unable to resize the window because the specified size exceeds the screen -size. On macOS, a window cannot be larger than the screen. +Unable to resize the window because the specified size exceeds the screen size. On macOS, a window cannot be larger than the screen. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ From a2635041f30686a46c001b66b4e151dcc62baf33 Mon Sep 17 00:00:00 2001 From: miherlosev Date: Tue, 10 May 2022 03:19:39 +0400 Subject: [PATCH 4/4] update etalons 2 --- .../expected-test-run-errors/action-cookie-arguments-error | 3 +-- .../data/expected-test-run-errors/action-date-option-error | 3 +-- .../data/expected-test-run-errors/action-number-option-error | 3 +-- .../data/expected-test-run-errors/action-string-option-error | 3 +-- 4 files changed, 4 insertions(+), 8 deletions(-) diff --git a/test/server/data/expected-test-run-errors/action-cookie-arguments-error b/test/server/data/expected-test-run-errors/action-cookie-arguments-error index 973a48c8d5..e307e60fef 100644 --- a/test/server/data/expected-test-run-errors/action-cookie-arguments-error +++ b/test/server/data/expected-test-run-errors/action-cookie-arguments-error @@ -1,5 +1,4 @@ -The value of cookie number 1 (false) does not belong to an acceptable data -type: Object or String. +The value of cookie number 1 (false) does not belong to an acceptable data type: Object or String. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-date-option-error b/test/server/data/expected-test-run-errors/action-date-option-error index d4e24cf350..914ba37404 100644 --- a/test/server/data/expected-test-run-errors/action-date-option-error +++ b/test/server/data/expected-test-run-errors/action-date-option-error @@ -1,5 +1,4 @@ -The value of the "expires" option belongs to an unsupported data type -(string). The "expires" option only accepts Date type values. +The value of the "expires" option belongs to an unsupported data type (string). The "expires" option only accepts Date type values. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-number-option-error b/test/server/data/expected-test-run-errors/action-number-option-error index 025f57b83d..c84cb10cbb 100644 --- a/test/server/data/expected-test-run-errors/action-number-option-error +++ b/test/server/data/expected-test-run-errors/action-number-option-error @@ -1,5 +1,4 @@ -The value of the "maxAge" option belongs to an unsupported data type -(object). The "maxAge" option only accepts Number type values. +The value of the "maxAge" option belongs to an unsupported data type (object). The "maxAge" option only accepts Number type values. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/ diff --git a/test/server/data/expected-test-run-errors/action-string-option-error b/test/server/data/expected-test-run-errors/action-string-option-error index f6ff2bab5b..42ab4815a5 100644 --- a/test/server/data/expected-test-run-errors/action-string-option-error +++ b/test/server/data/expected-test-run-errors/action-string-option-error @@ -1,5 +1,4 @@ -The value of the "name" option belongs to an unsupported data type (object). -The "name" option only accepts String type values. +The value of the "name" option belongs to an unsupported data type (object). The "name" option only accepts String type values. Browser: Chrome 15.0.874.120 / macOS 10.15 Screenshot: /unix/path/with/