Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEMS plugin can't get information from source tag #971

Closed
swirocota opened this issue Apr 30, 2024 · 2 comments
Closed

MEMS plugin can't get information from source tag #971

swirocota opened this issue Apr 30, 2024 · 2 comments

Comments

@swirocota
Copy link

swirocota commented Apr 30, 2024

Lanraragi Version
Docker, 0.9.0

Detail
If source tag have 'http://' or 'https://', the plugin can't get gallery id and token.

image
image
As you can see, there is source tag. But the plugin reported that it couldn't get gallery id

Suggestion

In LANraragi/lib/LANraragi/Plugin/Metadata/MEMS.pm
image

$lrr_info->{existing_tags} =~ /source:(?:https?:\/\/)?e(?:x|-)hentai\.org\/g\/(\d+)\/([0-9a-z]+)(?:\/)?/i
@Difegue
Copy link
Owner

Difegue commented May 1, 2024

source tags normally shouldn't contain the protocol; it's easy to update the regex to accomodate I guess, but I wouldn't want to encourage that.. Also you'd need to update every plugin that can do source lookups

@Doraemoe
Copy link

I believe this was fixed in #921. It should work if you use nightly build.

Repository owner locked and limited conversation to collaborators May 29, 2024
@Difegue Difegue converted this issue into discussion #978 May 29, 2024

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants