Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when clicking the icon on the account entry #389

Open
talbenbasat opened this issue Jan 23, 2016 · 0 comments
Open

Bug when clicking the icon on the account entry #389

talbenbasat opened this issue Jan 23, 2016 · 0 comments

Comments

@talbenbasat
Copy link

hi,

There is a bug when trying to connect with an account and clicking on the icon instead of clicking on the text.

The case is that you click on the tag instead of on the button tag,
so the this refers to the font awesome and :
$(event.target).attr('id').replace 'entry-', '' - fails
since this isn't the button

the bug can be solved by changing the accounts-entry/client/views/social/social.coffee (Line 28) to check for this case.

you can easily add an if statement to check if there is an id or not,
if not skip and then it will propagate.
another option is to check for the parent node instead of propagation.

Tal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant