Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task] Upgrade to TypeScript 3.8.0 #740

Closed
5 tasks done
Jack-Works opened this issue Feb 5, 2020 · 2 comments · Fixed by #911
Closed
5 tasks done

[Task] Upgrade to TypeScript 3.8.0 #740

Jack-Works opened this issue Feb 5, 2020 · 2 comments · Fixed by #911
Labels
Non-Coding Task
Milestone
M3E

Comments

@Jack-Works
Copy link
Member

Jack-Works commented Feb 5, 2020 •
edited

TypeScript 3.8.0 brings a group of amazing feature including

  • New export * as ns Syntax
  • Top-Level Await
  • Private Fields
  • import type syntax

Blocking by

Tasks

  • Upgrade those packages
  • Switch all possible imports to import type syntax.
@neruthes neruthes added this to the Backlog milestone Feb 24, 2020
@septs
Copy link
Contributor

septs commented Feb 26, 2020

@Jack-Works The week upgrade?

@septs septs modified the milestones: Backlog, M3 Feb 26, 2020
@Jack-Works
Copy link
Member Author

@Jack-Works The week upgrade?

No, we need to wait for prettier and eslint support new syntax

@Jack-Works Jack-Works modified the milestones: M3, M4 Feb 26, 2020
@neruthes neruthes modified the milestones: M4, M5 Mar 2, 2020
@Jack-Works Jack-Works mentioned this issue Mar 24, 2020
Merged
@neruthes neruthes modified the milestones: M5, M4 Mar 26, 2020
@neruthes neruthes modified the milestones: M4, M3E May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Non-Coding Task
Projects
None yet
Milestone
M3E
Development

Successfully merging a pull request may close this issue.

Switch to type only import & upgrade to prettier 2.0 DimensionDev/Maskbook
3 participants
@neruthes @septs @Jack-Works