Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DMG files broken because of assembly signing #274

Open
RickRockhold opened this issue Feb 11, 2023 · 3 comments
Open

DMG files broken because of assembly signing #274

RickRockhold opened this issue Feb 11, 2023 · 3 comments

Comments

@RickRockhold
Copy link

DiscUtils uses strongly-named assemblies, but the referenced lzfse-net package is not strongly signed, so it can't be loaded. This means the most modern DMG files can't be read.

@LTRData
Copy link

LTRData commented Feb 12, 2023

Signing strong named assemblies is mostly deprecated now so this typically does not matter. That is, unless you need to use the library in .NET Framework applications where you need to import the library into the GAC. That requires strongly named assemblies and only strongly named assemblies can be referenced from them.

https://github.com/dotnet/runtime/blob/main/docs/project/strong-name-signing.md

@RickRockhold
Copy link
Author

I'm using the library with .NET 4.7.2, and I'm not importing into the GAC. But the library doesn't work--.NET won't allow DiscUtils to load lzfse-net, because .NET won't let assemblies with a strong name to load an assembly without a strong name.

So in this configuration, the library is unusable.

@LTRData
Copy link

LTRData commented Feb 12, 2023

I see. I think the easiest solution to such scenarios is to build another version without the signing. Since the signing is needed in some other cases.

Or maybe the other way around, maybe the packages should nowadays contain not-signed files and those who need strongly named files could generate a key and build their own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants