-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
For DiscUtils.Iso9660.CDBuilder I can't use single wildCard like cd.Root.GetFiles("*") #287
Comments
This is expected, or? |
I am running into the same issue GetFiles("*") is returning 0 items as the wildcard conversion adds a point to the end by itself basically forcing every file in the filesystem to need a point in its name somewhere to be found, from source: if (!pattern.Contains("."))
{
pattern += ".";
}
So it is not possible to search files without a point (.) in the name? This is also incompatible with existing .net api as there a * can match any character including a . so it should find literally all files including those with a dot. |
Excuse my last post as it seems to be wrong, i was having another issue. The dot is not forced as a dot but as regex any character. However if i compare discutils with .net/windows i still see a difference:
|
Okay, I understand now and yes, you are right. It comes down to a partially broken implementation with regular expressions to filter searches. It is not only broken, but the performance is also pretty bad. In my fork of DiscUtils, I did this a bit differently: |
CDReader cd = new CDReader(fs, true, true);
cd.Root.GetFiles("") always return 0 results.
cd.Root.GetFiles(".*") works fine, but when you want to return files that don't have extension, that's annoying.
The text was updated successfully, but these errors were encountered: