Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature request: ApplicationCommands implementation in core module #1002

Open
psygate opened this issue Sep 12, 2021 · 0 comments
Open

feature request: ApplicationCommands implementation in core module #1002

psygate opened this issue Sep 12, 2021 · 0 comments
Milestone

Comments

@psygate
Copy link

psygate commented Sep 12, 2021

Feature Description:

API components like ApplicationCommandData use Strings as ids, while Rest API components like ApplicationService#deleteGlobalApplicationCommand take Longs as IDs. The intention to have the ApplicationService properly typed and not just operate on raw data is visible in ApplicationService#createGlobalApplicationCommand(long applicationId, ApplicationCommandRequest request). This should be normalized and all ApplicationService methods should either use primitives with explicit casting mechanisms (IDs become Snowflakes and the dev explicitly casts to snowflakes), or all methods should use intermittent types like Snowflakes or directly take the existing ApplicationCommandData as an argument. Number 2 makes more sense, since you can only ever delete an existing command, but creates more interdependency with the Discord-JSON Subproject

Justification: It's not clear which parts of the API are supposed to fit together and work together when primitive types like Strings are used on the one side and the other sides requires explicitly casted types like longs or snowflakes.

@quanticc quanticc added this to the 3.2.1 milestone Sep 17, 2021
@NovaFox161 NovaFox161 mentioned this issue Sep 27, 2021
8 tasks
@quanticc quanticc modified the milestones: 3.2.1, 3.2.2 Nov 11, 2021
@quanticc quanticc modified the milestones: 3.2.2, 3.2.x Backlog Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants