Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract common parts of message-related specs to supertype #1023

Open
darichey opened this issue Oct 6, 2021 · 0 comments
Open

Extract common parts of message-related specs to supertype #1023

darichey opened this issue Oct 6, 2021 · 0 comments
Labels
area/core Related to core module: events, entities, clients, specs enhancement Improvement over an existing feature
Milestone
Backlog

Comments

@darichey
Copy link
Member

darichey commented Oct 6, 2021

Feature Description:
Create a common supertype for all of the message-related specs (MessageCreateSpec, MessageEditSpec, InteractionFollwupCreateSpec, InteractionReplyEditSpec, WebhookExecuteSpec, etc.) with their common fields.

Justification:
The fact that these types are effectively unrelated (Spec doesn't help) makes writing code that works with any of them very difficult. Users have come up with various (ugly) solutions like writing adapters from MessageCreateSpec to the other specs.
@darichey darichey added enhancement Improvement over an existing feature area/core Related to core module: events, entities, clients, specs labels Oct 6, 2021
@darichey darichey added this to the Backlog milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/core Related to core module: events, entities, clients, specs enhancement Improvement over an existing feature
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@darichey