Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code sample issues #9

Open
bradvogel opened this issue May 21, 2014 · 0 comments
Open

Code sample issues #9

bradvogel opened this issue May 21, 2014 · 0 comments

Comments

@bradvogel
Copy link

There are a few minor code style inconsistencies:

Spaces in function declaration
function() {

vs

function(){
Missing semi-colons, e.g.
Template.notification.helpers({
   notificationPostPath: function() {
        return Router.routes.postPage.path({_id: this.postId});
   }
})
Single vs double quotes, e.g.
throw new Meteor.Error(401, "You need to login to make comments");
...
throw new Meteor.Error(422, 'Please write some content');
Single line functions vs multiple lines, e.g.
this.route('postPage', {
  path: '/posts/:_id',
  waitOn: function() {
    return Meteor.subscribe('comments', this.params._id); 
  },
  data: function() { return Posts.findOne(this.params._id); }
});
Also, it would be more readable if comments were complete sentences, e.g.
// Display the error to the user.

instead of:

// display the error to the user
@bradvogel bradvogel changed the title Minor code sample inconsistencies Code sample issues May 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant