Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent transitioning to an available state if project has bad pages #774

Open
srjfoo opened this issue Feb 11, 2022 · 0 comments
Open

Prevent transitioning to an available state if project has bad pages #774

srjfoo opened this issue Feb 11, 2022 · 0 comments

Comments

@srjfoo
Copy link
Member

srjfoo commented Feb 11, 2022

Resolving pages that have been marked bad works okay as long as the PM or a PF or squirrel takes care of fixing them.

Current process: If a project has 10 pages marked bad by 3 or more proofreaders, the project is marked bad and removed from the round. The PM gets an email for each page marked bad as it's marked bad.

The PM can then let it sit in the bad project state, fix the bad pages, or pull it to Unavailable.

If a project has 1-9 pages marked bad, the PM gets notifications when the pages are marked bad, but the project is not moved to the bad state, and sits in the round until someone does something about it.

As far as I can tell, PMs and PFs cannot do anything but move the project to unavailable, or back to waiting, or fix the bad pages. However, there is no block to keep a site admin from skipping a round if the project was marked bad and then moved to Unavailable.

No squirrel worth their salt would actually deliberately do something like that to a real project, but might do so accidentally. The question is, how should we be dealing with bad pages differently?

It's probably not enough to just mark the project bad. The transition from available or waiting to unavailable should be allowed if there are bad pages, but a transition from any waiting state to any available state should not be allowed if there are bad pages.

It's reasonable to allow a project to proceed through the round if there are a small number of pages marked bad, but if the project finishes a round with any bad pages, it should probably be moved to the bad state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant