Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comparison with go-errorlint (https://github.com/polyfloyd/go-errorlint) #18

Open
Antonboom opened this issue Jan 24, 2021 · 1 comment

Comments

@Antonboom
Copy link

Antonboom commented Jan 24, 2021

Hello!

At the moment, in golangci-lint, we have two linters that perform the same functionality.

Your linter appeared later, but it seems to have more options.

I would suggest:

  1. Implement errors.As (Add support for errors.As #14)
  2. Make exceptions / flags for dynamic errors (Strictness with parametrized errors #10)
  3. As a request from me: to require the creation of an error through the error.New if there are no formatting arguments:
var MyError  = fmt.Errorf("some error")
  1. Support type switches.

And then that go-errorlint can be asked to archive :)

What do you think? If you do not mind the points above, I can try to find the time and help you implement them.

@onokonem
Copy link
Member

onokonem commented Jan 25, 2021

Hi Anton,

all the 4 points looks reasonable (except 2 for me, but lets it go)

I'll be extremely busy myself for the next 4-6 weeks though :(

so any help would be highly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants