Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard shortcuts not working in an empty group #1149

Open
LaurentAtJoes opened this issue Mar 6, 2024 · 3 comments
Open

keyboard shortcuts not working in an empty group #1149

LaurentAtJoes opened this issue Mar 6, 2024 · 3 comments

Comments

@LaurentAtJoes
Copy link

Describe the bug
It seems when we are in an "empty" group (just showing an empty tab, if that's how your browser is set up), none of the shortcuts are effective anymore.
Whether it's the two that are configured by default, or any new custom one.

To Reproduce
Steps to reproduce the behavior:
Create at least 2 or 3 groups, open some websites in all but the last one (you may have to "load" the last group with an empty tab, though), then from a "populated" group, use shortcuts. Once you get to the "empty" group, you're stuck, you can't move away using shortcuts.

Expected behavior
Shortcuts should be usable too from an empty group, otherwise it just makes them useless overall.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS and version: Windows 10
  • Firefox version: 123.0
  • Simple Tab Groups version: 5.2

Additional context
This might be related to issue #957

@achernyakevich-sc
Copy link

@LaurentAtJoes

There are specificies how Firefox Add-Ons work. These can't track shortcuts for non web pages - empty pages or pages representing Firefox chrome or web extension.

You mentioned that loaded empty group and empty page. As page is empty - add-ons shortcuts does not work. Try to open any web page and use shortcut. If it works then it is your case and you can close this issue.

@LaurentAtJoes
Copy link
Author

Got it, didn't know that, thanks for your explanations.
Indeed if I open any web page, shortcuts come back to life.

It's a bit of a shame when using "next/previous" shortcuts to cycle through groups, because landing in an "empty" group disrupts the keyboard navigation.
And actually, I saw there are shortcut actions to "go to next/previous not empty group" (sorry if the phrasing isn't correct, I'm using French UI), but these don't seem to prevent landing in a group with just a "blank" tab (obviously not detected as empty).

Maybe this could be improved, and the plug-in could consider a group with just an empty tab as empty too ?
Because as soon as you display an empty (strictly) group, FF opens an empty tab, so it's no more detected as empty.

@SadBoiLlama
Copy link

SadBoiLlama commented Apr 11, 2024

if you set the bind in the firefox add-ons manager then itll work on the empty tabs and tell you if youre trying to overwrite other binds. apparently?

Screenshot 2024-04-10 224249

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants