Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SDWebImage to 5.18.7 or higher for privacy manifest before Apple's May 1 deadline #1031

Open
owjsub opened this issue Mar 12, 2024 · 4 comments · May be fixed by #1034
Open

Update to SDWebImage to 5.18.7 or higher for privacy manifest before Apple's May 1 deadline #1031

owjsub opened this issue Mar 12, 2024 · 4 comments · May be fixed by #1034
Labels

Comments

@owjsub
Copy link

owjsub commented Mar 12, 2024

Please update SDWebImage to 5.18.7 or higher to provide privacy manifest before Apple's May 1 deadline per https://developer.apple.com/news/?id=3d8a9yyh and https://developer.apple.com/support/third-party-SDK-requirements/

@owjsub owjsub added the bug label Mar 12, 2024
@owjsub owjsub changed the title Update to SDWebImage to 5.18.7 or higher for privacy manifest before Apple May 1 deadline Update to SDWebImage to 5.18.7 or higher for privacy manifest before Apple's May 1 deadline Mar 12, 2024
@Naturalclar
Copy link
Contributor

Since this repo seems to be inactive for a while, I've made a temporal fork for a work around

https://www.npmjs.com/package/@naturalclar/react-native-fast-image

diff: 4736c14

can be installed
pnpm i @naturalclar/react-native-fast-image

@devinbrown7
Copy link

@Naturalclar Thank you for this!

I just wanted to suggest that you change the repo link on the NPM page to point to your fork so the source code of your NPM package can be evaluated. I found it myself, but it'd be better if it was linked on the NPM package page.

@vasylnahuliak
Copy link

I would prefer to use the patch-package

@adamivancza
Copy link

here is a patch file that you can use:

diff --git a/node_modules/react-native-fast-image/RNFastImage.podspec b/node_modules/react-native-fast-image/RNFastImage.podspec
index db0fada..9cfa79e 100644
--- a/node_modules/react-native-fast-image/RNFastImage.podspec
+++ b/node_modules/react-native-fast-image/RNFastImage.podspec
@@ -16,6 +16,6 @@ Pod::Spec.new do |s|
   s.source_files  = "ios/**/*.{h,m}"
 
   s.dependency 'React-Core'
-  s.dependency 'SDWebImage', '~> 5.11.1'
+  s.dependency 'SDWebImage', '~> 5.18.7'
   s.dependency 'SDWebImageWebPCoder', '~> 0.8.4'
 end

react-native-fast-image+8.6.3.patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants