Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Cannot read properties of undefined (reading 'instance') #660

Closed
nelsonni opened this issue Mar 4, 2022 · 0 comments · Fixed by #656 or #807
Closed

Uncaught TypeError: Cannot read properties of undefined (reading 'instance') #660

nelsonni opened this issue Mar 4, 2022 · 0 comments · Fixed by #656 or #807
Assignees
Labels
bug Bug reports or bug fixes

Comments

@nelsonni
Copy link
Member

nelsonni commented Mar 4, 2022

Describe the bug
Synectic v1.2.0 does not throw this error. However, inspecting the updates reveals that v1.3.0 includes updating to electron@17.0.0 which appears to have a regression related to webContents.openDevTools({mode}) and specifically mode passing (see electron/electron#32768, electron/electron#32702). There is a fix introduced in electron/electron#32829, and was backported to the electron 17.x.y series in electron/electron#32945 and included in electron@17.1.0

[11018:0303/212304.206992:ERROR:CONSOLE(1)] "Uncaught TypeError: Cannot read properties of undefined (reading 'instance')", source: devtools://devtools/bundled/devtools_app.html?remoteBase=https://chrome-devtools-frontend.appspot.com/serve_file/@7f5320c63197ddacf4c8094154bd0cd63af422b5/&can_dock=true&toolbarColor=rgba(223,223,223,1)&textColor=rgba(0,0,0,1)&experiments=true (1)
[11021:0303/212519.453582:ERROR:node_controller.cc(585)] Trying to re-add dropped peer 320DC7598F384DD7.C5E34462C9597B91

To Reproduce
Steps to reproduce the behavior:

  1. Launch Synectic from source (i.e. yarn start)
  2. Wait for successful compile & build
  3. See error

Expected behavior
Electron should allow for the loading and docking of DevTools without errors.

Screenshots
Screen Shot 2022-03-03 at 9 26 54 PM

Versions (please complete the following information):

  • OS: MacOS
  • Synectic Version: 1.4.1

Additional context
Will be resolved by #656.

@nelsonni nelsonni added the bug Bug reports or bug fixes label Mar 4, 2022
@nelsonni nelsonni self-assigned this Mar 4, 2022
@nelsonni nelsonni linked a pull request Mar 4, 2022 that will close this issue
@nelsonni nelsonni closed this as completed Mar 7, 2022
@nelsonni nelsonni reopened this Mar 7, 2022
@nelsonni nelsonni mentioned this issue Jun 7, 2022
@nelsonni nelsonni linked a pull request Jun 13, 2022 that will close this issue
@nelsonni nelsonni changed the title Uncaught TypeError: Cannot read properties of undefined (reading 'instance') Uncaught TypeError: Cannot read properties of undefined (reading 'instance') Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports or bug fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant