Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button not centered in banner #221

Open
brianking opened this issue Nov 18, 2020 · 1 comment
Open

Button not centered in banner #221

brianking opened this issue Nov 18, 2020 · 1 comment
Labels
priority:low

Comments

@brianking
Copy link

In the notice banner, the 'Got it' button to dismiss is not centered to the text.

Screenshot 2020-11-18 at 12 29 19
@brianking brianking mentioned this issue Jan 25, 2021
Closed
@kineticsquid
Copy link
Contributor

I think the design point on this is the 'Got it' button is in the lower right. It only looks a bit funny when there is one line of text. With two or three lines, it appears purposeful.

image

image

Unless someone disagrees, I'm inclined to close as working as designed. @croundy @brianking?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority:low
Projects
Open-vsx.org Deployment
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brianking @kineticsquid