Skip to content
This repository has been archived by the owner on May 27, 2023. It is now read-only.

Controller Unit Test Improvements #279

Open
Ig0r-M-magic42 opened this issue Dec 6, 2016 · 4 comments
Open

Controller Unit Test Improvements #279

Ig0r-M-magic42 opened this issue Dec 6, 2016 · 4 comments

Comments

@Ig0r-M-magic42
Copy link

While creating for another project a unit test for controller there appeared a problem:
They were not starting, found problem at lib/EcomDev/PHPUnit/Mock/Proxy.php wich implements PHPUnit_Framework_MockObject_MockObject and is required to implement also function __phpunit_hasMatchers.
I have raised a PR which fixes this issue.

Also my IDE shows following error
screenshot from 2016-12-06 15 54 38. Fortunately for me this has not stopped testing controller

@Ig0r-M-magic42
Copy link
Author

Apparently i don't have access to push so i will just post here what i have added. Hope this will help other

screenshot from 2016-12-06 15 57 31

@p-makowski
Copy link

@Ig0r-M Fork this repository, push your changes to forked repo and create a pull request from it to this one.

@Ig0r-M-magic42
Copy link
Author

@p-makowski thanks for clarifying. Raised PR #280 for this.

@Ig0r-M-magic42
Copy link
Author

Regarding PHPStorm being noisy about method() to be implemented is related to sebastianbergmann/phpunit#1680.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants