Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve accessibility of the project #313

Merged
merged 2 commits into from
Dec 17, 2023
Merged

feat: improve accessibility of the project #313

merged 2 commits into from
Dec 17, 2023

Conversation

Hristo-Spasov
Copy link
Contributor

Fixes Issue

Closes #302

Changes proposed

One of the suggested changes is related to a <iframe> element which cannot be change within the Application,therefore is not changed.

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Get started button

primaryFeatures

Note to reviewers

After picking up the issue i have to admit it took a minute until i can track the exact texts that need a change.
With these changes I do believe the text looks better and is way more readable.

@vercel Vercel
Copy link

vercel bot commented Nov 12, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2023 3:03pm

@fi-krish
Copy link
Member

Hi! Quick Question: Does this fix everything apart from the Element 6 (the one in the iframe)?

@fi-krish fi-krish added the enhancement New feature or request label Nov 13, 2023
@fi-krish fi-krish changed the title adding the changes suggested in issue#302 feat: improve accessibility of the project Nov 13, 2023
@Hristo-Spasov
Copy link
Contributor Author

Hristo-Spasov commented Nov 13, 2023 •
edited

Yes,the errors from "Elements must meet minimum color contrast ratio thresholds to meet the WCAG 2 AA" that are not related to the iframe are gone.

@fi-krish fi-krish mentioned this pull request Dec 17, 2023
Open
@fi-krish fi-krish merged commit 9ded83d into EddieHubCommunity:main Dec 17, 2023
2 checks passed
@Hristo-Spasov Hristo-Spasov deleted the issue302 branch January 9, 2024 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Color Contrast Not High Enough
2 participants
@Hristo-Spasov @fi-krish