Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "mark as favorite" button: #354

Open
nithin999989 opened this issue Jun 12, 2023 · 9 comments
Open

Add a "mark as favorite" button: #354

nithin999989 opened this issue Jun 12, 2023 · 9 comments

Comments

@nithin999989
Copy link
Member

Description

A "mark as favorite" button can be added to the website to allow users to save issues that they are interested in working on for later reference.

Screenshots

No response

Additional information

No response

@Cahllagerfeld
Copy link
Member

Thanks for raising!

I think this is currently not in the scope of the project, as it's not using a database to store any data in.
As of now, it's also not planned to add a database to it

@tbhaxor
Copy link
Member

tbhaxor commented Aug 19, 2023

Thanks for raising!

I think this is currently not in the scope of the project, as it's not using a database to store any data in. As of now, it's also not planned to add a database to it

We can store in localStorage

@Cahllagerfeld
Copy link
Member

Persisting it to localStorage is a good idea 👍 Lets do it!

Todos:

  • Update UI accordingly, by adding a Starbutton or something similar to the issue
  • Creating a new Favorite and persist it in localStorage
  • Removing a favorite and adjust localStorage accordingly
  • Reading localStorage while loading the issues

Did I miss something?

@tbhaxor
Copy link
Member

tbhaxor commented Aug 20, 2023

I could work on this, but not good with UI and styling.

@ShahIsCoding
Copy link

i want to work on this can you assign this to me

@Cahllagerfeld
Copy link
Member

Sure 👍

@Babuprasanth27
Copy link

hey, I am interested to work in this button.

@ShahIsCoding ShahIsCoding removed their assignment Oct 16, 2023
@namrata18s
Copy link

namrata18s commented Nov 26, 2023

hi @Cahllagerfeld, can I work on this?
additionally could you guide me on which files do I need to look? Thankyou in advance

@Cahllagerfeld
Copy link
Member

Do you have experience with svelte and sveltekit, I wouldn't consider this a good-first issue. Also you're having another open PR currently, lets get that merged before 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants