Closes #365 - Added animated gradient text effect to main heading. (Improvement) #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue EddieHubCommunity#365 - Added animated gradient text effect to main heading. (Improvement)
Applied the media query for reduced motion, removed additional CSS file.
|
@Cahllagerfeld Kindly review the PR. |
|
No worries about the ping :) You are right Cahl, the animation should not show if the user has enabled the prefers-reduced-motion setting. |
|
@EmmaDawsonDev, @Cahllagerfeld I have updated the code as per the review comments. Kindly review it |
| animation: gradientAnimation 2s linear infinite alternate-reverse; | ||
| } | ||
|
|
||
| @media (prefers-reduced-motion: reduce) { |
There was a problem hiding this comment.
We don't need a dedicated media-query here, tailwind also provides them out-of-the-box with reduced-motion: see their docs
| } | ||
| } | ||
|
|
||
| @media (min-width: 768px) { |
There was a problem hiding this comment.
Same as above, but for responsive breakpoints [resource]
|
closing this for now, due to lack of activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue
Changes proposed
Check List (Check all the applicable boxes)
Screenshots
screen-capture.webm
Note to reviewers