Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Light Mode and Dark Mode buttons sticky #394

Open
AniketNS opened this issue Nov 15, 2023 · 7 comments · May be fixed by #395
Open

Make Light Mode and Dark Mode buttons sticky #394

AniketNS opened this issue Nov 15, 2023 · 7 comments · May be fixed by #395

Comments

@AniketNS
Copy link

Description

I think the light mode and dark mode button should be sticky on the right most upper side of the page. I had to scroll down all the way to footer, every time I wanted to switch the theme.

I'd like to know your thoughts about this.

Screenshots

No response

Additional information

No response

@NextThread
Copy link

NextThread commented Nov 19, 2023

can i work on this issue? @eddiejaoude

@AniketNS
Copy link
Author

I'm not a maintainer @NextThread, You should ask @eddiejaoude or any other maintainer.

@namrata18s
Copy link

namrata18s commented Nov 24, 2023

hey @eddiejaoude , I would like to work on this issue. Thankyou in advance.

@Cahllagerfeld
Copy link
Member

Just for my understanding, do you want to bring the switcher to the navbar, or do you want to rework the navbar?
I think when bringing the switcher to the top we also need to rework it, so it doesn't use that much space in the header

@immortalAbdul01
Copy link

I think making it sticky at the bottom would be good, as there will be too many things on the top right side.

@namrata18s
Copy link

I think the themes are generally at the top of the page to ensure visibility for users.
@eddiejaoude @Cahllagerfeld, I kindly request your review of the pull request associated with issue #395. Additionally, please advise if any adjustments are needed in the navbar

@Cahllagerfeld
Copy link
Member

Hey @namrata18s and @immortalAbdul01 to me it's still not 100% clear how this should be have given me keep it in the footer. Will we need a sticky footer then, or did you imply something else with your idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants