Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate using Vitest in combination with Effect as testing setup #1063

Closed
2 tasks
schickling opened this issue Jan 25, 2022 · 2 comments
Closed
2 tasks
Labels
breaking Breaking change enhancement New feature or request

Comments

@schickling
Copy link

schickling commented Jan 25, 2022

I really like the Vite-backed "HMR" system applied to testing workflows as demonstrated here: https://twitter.com/antfu7/status/1468233216939245579

We should investigate how Vitest can be used in Effect projects.

I'm currently running in the following problems:

  • Effect should use fully qualified import paths (e.g. import {} from './some-file.js' instead of import {} from './some-file'). Possibly related to Errors from running Vite nodejs tests vitest-dev/vitest#202
    image
  • Effect currently relies on running tsc for the sake of applying the tsc-plugin. This massively slows down the refresh cycle.
@mikearnaldi
Copy link
Member

mikearnaldi commented Jan 26, 2022

Effect currently relies on running tsc for the sake of applying the tsc-plugin. This massively slows down the refresh cycle.

Effect doesn't rely on any compiler plugin, if you want features like tracing and optimization the compiler plugin is a non avoidable requirement given that the functionality relies on knowledge of the types but if you don't care about those features you can compile using any tool.

Effect should use fully qualified import paths

It is a major change that is already in the workings for the next release and will be addresses in the compiler extension, probably won't happen in current unless we manage to find a quick solution

@mikearnaldi
Copy link
Member

Resolved in recent releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

2 participants