Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WalletSnapshot.canSpend() calculation limitation #1370

Open
HonzaR opened this issue Apr 19, 2024 · 0 comments
Open

WalletSnapshot.canSpend() calculation limitation #1370

HonzaR opened this issue Apr 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@HonzaR
Copy link
Collaborator

HonzaR commented Apr 19, 2024

Is your feature request related to a problem? Please describe.

Once we know how to solve this properly, we'd like to address this inlined comment:

// Note this check is not entirely correct - it does not calculate the resulting fee using the new Proposal API. It's
// fine for now, but it's subject to improvement later once we figure out how to handle it in such cases.
fun WalletSnapshot.canSpend(amount: Zatoshi): Boolean = spendableBalance() >= amount

Describe the solution you'd like

For example, can we count the latest calculated and stored fee value with a fallback to 10K Zatoshi as a default value?

Alternatives you've considered

Additional context

@HonzaR HonzaR added the enhancement New feature or request label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant