Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receive: improve Receive screen UI by adding a toggle for addresses #1412

Open
true-jared opened this issue May 1, 2024 · 0 comments
Open
Labels
good first issue Issues that are good for someone new to the codebase to tackle P-high High priority S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. UI UI related tasks

Comments

@true-jared
Copy link

true-jared commented May 1, 2024

Is your feature request related to a problem? Please describe.

We'd like to rework the UI part of the Receive screen the way it splits the screen content and put it into two tabs parts of the viewpager.

On smaller devices, users do NOT see the transparent address at all with the current design. We decided to improve this by allowing the user to toggle between the unified and transparent address.

Describe the solution you'd like

The requested UI is described in the Figma design:
https://www.figma.com/design/vYQD6uZtkPgtmgJ3zfauq0/Zashi-UI?node-id=5328-100823&t=9LI3NGkrYTDbkPMo-0

Note that the underlying bottom tabs viewpager might not work properly if we add another swipeable component. Disabling the swipe gesture for the new viewpager is one possible solution. Is there any other useful solution for this case?

Additional context

Related classes are AndroidReceive.kt and ReceiveView.kt.

@true-jared true-jared added UI UI related tasks P-high High priority labels May 1, 2024
@true-jared true-jared added this to the Android Zashi 1.1 milestone May 1, 2024
@HonzaR HonzaR removed their assignment Jun 3, 2024
@HonzaR HonzaR added the good first issue Issues that are good for someone new to the codebase to tackle label Jun 3, 2024
@true-jared true-jared added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Issues that are good for someone new to the codebase to tackle P-high High priority S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. UI UI related tasks
Projects
None yet
Development

No branches or pull requests

2 participants