Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When receiving a multi-output transaction, all memos must be displayed #1418

Open
true-jared opened this issue May 1, 2024 · 1 comment · May be fixed by #1454 or #1455
Open

When receiving a multi-output transaction, all memos must be displayed #1418

true-jared opened this issue May 1, 2024 · 1 comment · May be fixed by #1454 or #1455
Labels
P-medium Medium priority UI UI related tasks
Milestone
Android Zashi 1.1

Comments

@true-jared
Copy link

true-jared commented May 1, 2024 •
edited by HonzaR

Is your feature request related to a problem? Please describe.

We'd like to introduce a better UX/UI for more messages in a transaction. Currently, we simply take the first one and omit the others.

Describe the solution you'd like

Check co.electriccoin.zcash.ui.screen.account.view.HistoryViewKt#HistoryItemMessagePart that stands for displaying messages (memos) in the UI layer. The data layer already provides all the messages.

Prepare the logic for displaying all the provided messages.

Design document link: https://www.figma.com/design/vYQD6uZtkPgtmgJ3zfauq0/Zashi-UI?node-id=5347-80177&t=xOqPOMFdqA7gSwI2-0
@true-jared true-jared added the UI UI related tasks label May 1, 2024
@true-jared true-jared added this to the Android Zashi 1.1 milestone May 1, 2024
@true-jared true-jared added the P-medium Medium priority label May 1, 2024
@HonzaR
Copy link
Collaborator

HonzaR commented May 2, 2024

Similar issue #1315

@HonzaR HonzaR added the good first issue Issues that are good for someone new to the codebase to tackle label May 29, 2024
@HonzaR HonzaR removed their assignment May 29, 2024
@HonzaR HonzaR mentioned this issue May 29, 2024
Closed
thats-bot pushed a commit to thats-bot/zashi-android that referenced this issue May 30, 2024
[Electric-Coin-Company#1418] - Display all transaction messages as a …
27c986c 
…separate items

- Closes Electric-Coin-Company#1418
thats-bot pushed a commit to thats-bot/zashi-android that referenced this issue May 30, 2024
[Electric-Coin-Company#1418] - Display all transaction messages as a …
dbe5d42 
…separate items

- Closes Electric-Coin-Company#1418
@thats-bot thats-bot linked a pull request May 30, 2024 that will close this issue
Open
13 tasks
thats-bot pushed a commit to thats-bot/zashi-android that referenced this issue May 30, 2024
[Electric-Coin-Company#1418] - Speed up search of valid memos
b5df611
thats-bot pushed a commit to thats-bot/zashi-android that referenced this issue May 30, 2024
[Electric-Coin-Company#1418] - Mention functionality in the changelog
0665ec5
thats-bot pushed a commit to thats-bot/zashi-android that referenced this issue May 30, 2024
[Electric-Coin-Company#1418] - Display all transaction messages as a …
5565bf9 
…separate items

- Closes Electric-Coin-Company#1418
- Fix new line indent
- Mention functionality in the changelog
thats-bot pushed a commit to thats-bot/zashi-android that referenced this issue May 30, 2024
[Electric-Coin-Company#1418] - Speed up search of valid memos
4ef343f
thats-bot pushed a commit to thats-bot/zashi-android that referenced this issue May 30, 2024
[Electric-Coin-Company#1418] - Display all transaction messages as a …
df8f5a0 
…separate items

- Closes Electric-Coin-Company#1418
- Fix new line indent
- Mention functionality in the changelog
thats-bot pushed a commit to thats-bot/zashi-android that referenced this issue May 30, 2024
[Electric-Coin-Company#1418] - Speed up search of valid memos
d0f644c
thats-bot pushed a commit to thats-bot/zashi-android that referenced this issue May 30, 2024
[Electric-Coin-Company#1418] - Speed up search of valid memos
84e1937
thats-bot pushed a commit to thats-bot/zashi-android that referenced this issue May 31, 2024
[Electric-Coin-Company#1259] - Add bubble message component
8df4aab 
- Closes Electric-Coin-Company#1418
- Wrap history and send message fields in bubble style
thats-bot pushed a commit to thats-bot/zashi-android that referenced this issue May 31, 2024
[Electric-Coin-Company#1259] - Add bubble message component
1633fd7 
- Closes Electric-Coin-Company#1418
- Wrap history and send message fields in bubble style
- Update changelog
thats-bot pushed a commit to thats-bot/zashi-android that referenced this issue May 31, 2024
[Electric-Coin-Company#1259] - Add bubble message component
0721e56 
- Closes Electric-Coin-Company#1418
- Wrap history and send message fields in bubble style
- Update changelog
@thats-bot thats-bot linked a pull request May 31, 2024 that will close this issue
Open
13 tasks
@HonzaR HonzaR removed the good first issue Issues that are good for someone new to the codebase to tackle label Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P-medium Medium priority UI UI related tasks
Projects
None yet
Milestone
Android Zashi 1.1
2 participants
@HonzaR @true-jared