Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow SDKSynchronizer to user arbitrary checkpoints instead of bundled ones #1334

Open
pacu opened this issue Jan 5, 2024 · 0 comments · May be fixed by #1335
Open

Allow SDKSynchronizer to user arbitrary checkpoints instead of bundled ones #1334

pacu opened this issue Jan 5, 2024 · 0 comments · May be fixed by #1335

Comments

@pacu
Copy link
Contributor

pacu commented Jan 5, 2024

Is your feature request related to a problem? Please describe.

This is something that would enable supporting Regtest checkpoints without the need of bundling
them inside the SDK. See #1216 and Electric-Coin-Company/zcash-swift-wallet-sdk#1331. for reference

Describe the solution you'd like

Make checkpointTool extend from an interface that can be used to inject the custom checkpoint provisioning in testing environments
pacu added a commit to pacu/zcash-android-wallet-sdk that referenced this issue Jan 5, 2024
@pacu
[Electric-Coin-Company#1334] WIP / Proposal Allow SDKSynchronizer to …
23eb28d 
…user arbitrary checkpoints instead of bundled ones

This is a draft PR intended to show the implementation I'd like to
propose. It does not compile for many reasons, like visibility of
checkpoint

would eventually close Electric-Coin-Company#1334
@pacu pacu linked a pull request Jan 5, 2024 that will close this issue
Draft
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@pacu