Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added github-api-url and change axios to got #135

Merged
merged 3 commits into from
Dec 8, 2021

Conversation

JasonCubic
Copy link
Contributor

I created PR so that the excellent version-check project would work in my enterprise environment. Hopefully it helps others as well.

Changes:

  • Changed axios to got. In a heavily firewalled and proxied envionment axios gets socket hang up errors, but got works fine.
  • added an optional workflow "with" value of github-api-url so that the project can be directed to an enterprise instance of github.

This change works for the enterprise instance of github at my company.

Note: your CONTRIBUTING.md file says not to include /lib/index.js but because husky forces this to be built I'm not sure how to exclude it without breaking husky?

@EndBug EndBug added the type: feature New feature or feature request label Dec 7, 2021
@EndBug
Copy link
Owner

EndBug commented Dec 7, 2021

First of all, thank you so much for the PR!
I don't have access to GitHub Enterprise, so I'll just take you word for the fact that it works when changing the URL.
I'll just test that it works as usual and then it'll be ready to be merged!

The contributing file is outdated, thank you for letting me know, I'll fix it later 👍🏻

@JasonCubic
Copy link
Contributor Author

That's great, thank you for reviewing.

@EndBug EndBug merged commit 0f71092 into EndBug:master Dec 8, 2021
@EndBug
Copy link
Owner

EndBug commented Dec 8, 2021

@all-contributors please add @JasonCubic for their code contribution

@allcontributors
Copy link
Contributor

@EndBug

I've put up a pull request to add @JasonCubic! 🎉

@EndBug
Copy link
Owner

EndBug commented Dec 8, 2021

Okay, I've published this feature in v2.1.0 (also pointed by v2 and latest). Thank you for the contribution ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature New feature or feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants