Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update dependency class-validator #153

Closed
jbjhjm opened this issue Apr 20, 2020 · 2 comments
Closed

Please update dependency class-validator #153

jbjhjm opened this issue Apr 20, 2020 · 2 comments

Comments

@jbjhjm
Copy link

jbjhjm commented Apr 20, 2020

class-validator finally introduced tree-shakable validators (since 0.12.0, see Pull 568).

This makes it a lot more compact to use and stops requiring hacks to exclude bold dependencies (libphonenumber, hundreds of KB).
Would you mind to push the version used by dynamic form builder? Thank you :)

Note: I just read about a breaking change which might require changes:
"all validations (except system ones) are type ValidationTypes.CUSTOM_VALIDATION now - mostly internal change"

If I do remember the source of dynamic form builder correctly, it distinguishes between several types.

@jbjhjm jbjhjm changed the title Please update class-validator Please update dependency class-validator Apr 20, 2020
@EndyKaufman
Copy link
Owner

done

@jbjhjm
Copy link
Author

jbjhjm commented May 5, 2020

Thank you :D

@jbjhjm jbjhjm closed this as completed May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants