Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perf Command Data Should Be Persistent On Server Restart #2293

Open
RitzKid76 opened this issue Apr 4, 2023 · 1 comment · May be fixed by #2367
Open

Perf Command Data Should Be Persistent On Server Restart #2293

RitzKid76 opened this issue Apr 4, 2023 · 1 comment · May be fixed by #2367
Labels
status:pending Pending acceptance or closure. type:feature-request Request for something new

Comments

@RitzKid76
Copy link

The Problem

The command //perf settings are reset to default every time the server is restarted. The user may not expect their settings to be reverted to default. Reverted settings create undesired outcomes other than what the user may have expected.

A Solution

Any setting changed under //perf should be stored in the persistent storage for world edit data. This would prevent players from constantly reminding themselves that their settings before the server restart may not be the same, which causes undesired behavior.

Alternatives

One alternative would be accessing these command settings through the API. Server admins could just implement their solutions to the problem instead. The self-implementation fix is not preferred because the developer may not even be aware of the issue in the first place.

Anything Else?

No response
@RitzKid76 RitzKid76 added status:pending Pending acceptance or closure. type:feature-request Request for something new labels Apr 4, 2023
@TomyLobo
Copy link
Collaborator

TomyLobo commented Apr 5, 2023 •
edited

If you want to implement this yourself, you can do this:

session.setSideEffectSet(session.getSideEffectSet().with(SideEffect.VALIDATION, SideEffect.State.ON));

On the matter of persisting it, by the looks of it, that should be as simple as removing the transient qualifier on the sideEffectSet field in the LocalSession class.
That should make the library WE uses for saving pick it up and persist it.
So if you want to change that in your personal fork, go ahead.

I can't say I'm in favor of doing that in WorldEdit itself, though.
Persisting //perf would probably lead to an increase in spurious bug reports and other noise.
But I don't have a dog in that fight, the devs might have other opinions.

@me4502 me4502 linked a pull request Jul 22, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:pending Pending acceptance or closure. type:feature-request Request for something new
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Preserve player-set side effects EngineHub/WorldEdit
2 participants
@TomyLobo @RitzKid76