Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable source maps in output by exposing browserify debug option #114

Open
tmaslen opened this issue Mar 13, 2021 · 1 comment
Open

Enable source maps in output by exposing browserify debug option #114

tmaslen opened this issue Mar 13, 2021 · 1 comment

Comments

@tmaslen
Copy link

tmaslen commented Mar 13, 2021

Hi,

This is a request which I think would make a great feature to this very useful plugin.

Could you optionally expose browserify's debug option, this would allow users to enable source maps and so benefit from better error stack traces even when the output is minified.

Browserify state that you can set debug: true to enable source maps...

       --debug -d  Enable source maps that allow you to debug your files
                   separately.

On this line here: https://github.com/FidelLimited/serverless-plugin-optimize/blob/master/src/index.js#L382

If you're open to it I'd like to make this in a pull request (this might take me a bit of time).

Thanks,
Tom.

@tmaslen
Copy link
Author

tmaslen commented Mar 21, 2021

I made this feature myself and stuck a PR in for you: #115

I've plugged my version up into my build and am now benefiting from nicer stack traces.

This was referenced Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant