Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize plugin breaks "Fastify" #86

Open
hakimio opened this issue Sep 9, 2019 · 3 comments
Open

Optimize plugin breaks "Fastify" #86

hakimio opened this issue Sep 9, 2019 · 3 comments

Comments

@hakimio
Copy link

hakimio commented Sep 9, 2019

Steps to reproduce

  1. Checkout fastify branch from hakimio/nest-serverless github repository
  2. Install dependencies: yarn install
  3. Try to run lambda function locally: yarn run test:sls

Results You Received:

sls invoke local fails with "Cannot convert undefined or null to object" error coming from fastify.

Results You Expected:

If you disable optimize plugin, the test succeeds with 200 response:

{
    "statusCode": 200,
    "body": "Hello World!",
    "headers": {
        "content-type": "text/plain; charset=utf-8",
        "content-length": "12",
        "date": "Mon, 09 Sep 2019 08:46:52 GMT",
        "connection": "keep-alive"
    },
    "isBase64Encoded": false
}

Environment Details:

Serverless: 1.51.0
serverless-plugin-optimize: 4.1.0-rc.1

@nabsofken
Copy link

@hakimio I am getting the same error. Did you manage to get it resolved?

@hakimio
Copy link
Author

hakimio commented Oct 31, 2020

This issue is pretty old, but, as far as I can remember, I just stopped using this plugin. I don't think I ever found any solution.

@hakimio
Copy link
Author

hakimio commented Oct 31, 2020

Just checked my git log: I just replaced this plugin with serverless-layers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants