Fix creating checks with more than 50 annotations #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Unit Test Results (Test Files) 24 files ±0 4 errors 21 suites ±0 39m 12s ⏱️ ±0s For more details on these parsing errors, failures and errors, see this check. Results for commit e9870ab. ± Comparison against base commit 043296c. ♻️ This comment has been updated with latest results. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Creating more than 50 annotations works: https://github.com/EnricoMi/publish-unit-test-result-action/runs/4860016192 |
EnricoMi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While looking into #212 it turned out that creating checks with more than 50 annotations does actually not work. The action creates multiple checks, which overwrites earlier checks. It does not produces the error reported in #212 though. This might have caused #183.
While testing this it turned out that if there are test names longer than
max_chunk_size, the action turns into an endless loop. This unlikely case is handled now by dropping all test names (skipping test list annotations entirely) while working otherwise.This fixes creation of checks with more than 50 annotations. This also fixes #214.