Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reset timestamps UTC, test with specific timezone #226

Merged
merged 2 commits into from
Feb 24, 2022

Conversation

EnricoMi
Copy link
Owner

@EnricoMi EnricoMi commented Feb 24, 2022

Fixes #225.

Reproduced in https://github.com/EnricoMi/python/runs/5324173294?check_suite_focus=true#step:5:179:

  2022-02-25 06:01:15 +1030 - publish-unit-test-results -  INFO - There is no Retry-After given in the response header
  2022-02-25 06:01:15 +1030 - publish-unit-test-results -  INFO - Response body indicates retry-able error: api rate limit exceeded for installation id 5425010.
  2022-02-25 06:01:15 +1030 - publish-unit-test-results - DEBUG - Response header contains X-RateLimit-Limit=30
  2022-02-25 06:01:15 +1030 - publish-unit-test-results - DEBUG - Response header contains X-RateLimit-Remaining=0
  2022-02-25 06:01:15 +1030 - publish-unit-test-results - DEBUG - Response header contains X-RateLimit-Reset=1645731119
  2022-02-25 06:01:15 +1030 - publish-unit-test-results - DEBUG - Response header contains X-RateLimit-Used=30
  2022-02-25 06:01:15 +1030 - publish-unit-test-results - DEBUG - Response header contains X-RateLimit-Resource=search
  2022-02-25 06:01:15 +1030 - publish-unit-test-results -  INFO - Reset occurs in 10:30:43.026608 (2022-02-25 06:01:59), setting next backoff to 37843.026608s

Fixed in https://github.com/EnricoMi/python/runs/5324190458?check_suite_focus=true#step:5:173:

  2022-02-25 06:02:45 +1030 - publish-unit-test-results -  INFO - There is no Retry-After given in the response header
  2022-02-25 06:02:45 +1030 - publish-unit-test-results -  INFO - Response body indicates retry-able error: api rate limit exceeded for installation id 5425010.
  2022-02-25 06:02:45 +1030 - publish-unit-test-results - DEBUG - Response header contains X-RateLimit-Limit=30
  2022-02-25 06:02:45 +1030 - publish-unit-test-results - DEBUG - Response header contains X-RateLimit-Remaining=0
  2022-02-25 06:02:45 +1030 - publish-unit-test-results - DEBUG - Response header contains X-RateLimit-Reset=1645731180
  2022-02-25 06:02:45 +1030 - publish-unit-test-results - DEBUG - Response header contains X-RateLimit-Used=30
  2022-02-25 06:02:45 +1030 - publish-unit-test-results - DEBUG - Response header contains X-RateLimit-Resource=search
  2022-02-25 06:02:45 +1030 - publish-unit-test-results -  INFO - Reset occurs in 0:00:14.222318 (1645731180 / 2022-02-24 19:33:00), setting next backoff to 14.222318s

@github-actions
Copy link

github-actions bot commented Feb 24, 2022

Unit Test Results (Linux)

       54 files  +     36         54 suites  +36   2m 27s ⏱️ + 1m 19s
     261 tests ±       0       261 ✔️ ±       0      0 💤 ±    0  0 ±0 
14 094 runs  +9 396  13 662 ✔️ +9 108  432 💤 +288  0 ±0 

Results for commit 9725ff9. ± Comparison against base commit d0787a9.

♻️ This comment has been updated with latest results.

@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented Feb 24, 2022

Unit Test Results (macOS)

       54 files  +     36         54 suites  +36   2m 27s ⏱️ + 1m 19s
     261 tests ±       0       261 ✔️ ±       0      0 💤 ±    0  0 ±0 
14 094 runs  +9 396  13 662 ✔️ +9 108  432 💤 +288  0 ±0 

Results for commit 9725ff9. ± Comparison against base commit d0787a9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 24, 2022

Unit Test Results (Test Files)

  24 files  ±0      4 errors  21 suites  ±0   39m 12s ⏱️ ±0s
272 tests ±0  227 ✔️ ±0  18 💤 ±0  23 ±0  4 🔥 ±0 
437 runs  ±0  354 ✔️ ±0  53 💤 ±0  25 ±0  5 🔥 ±0 

For more details on these parsing errors, failures and errors, see this check.

Results for commit 9725ff9. ± Comparison against base commit d0787a9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 24, 2022

Unit Test Results (Dockerfile)

       54 files  +     36         54 suites  +36   2m 27s ⏱️ + 1m 19s
     261 tests ±       0       261 ✔️ ±       0      0 💤 ±    0  0 ±0 
14 094 runs  +9 396  13 662 ✔️ +9 108  432 💤 +288  0 ±0 

Results for commit 9725ff9. ± Comparison against base commit d0787a9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 24, 2022

Unit Test Results (Docker Image)

       54 files  +     36         54 suites  +36   2m 27s ⏱️ + 1m 19s
     261 tests ±       0       261 ✔️ ±       0      0 💤 ±    0  0 ±0 
14 094 runs  +9 396  13 662 ✔️ +9 108  432 💤 +288  0 ±0 

Results for commit 9725ff9. ± Comparison against base commit d0787a9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 24, 2022

Unit Test Results (Windows)

       54 files  +     36         54 suites  +36   2m 27s ⏱️ + 1m 19s
     261 tests ±       0       261 ✔️ ±       0      0 💤 ±    0  0 ±0 
14 094 runs  +9 396  13 662 ✔️ +9 108  432 💤 +288  0 ±0 

Results for commit 9725ff9. ± Comparison against base commit d0787a9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 24, 2022

Unit Test Results (reference)

       54 files  +     36         54 suites  +36   2m 27s ⏱️ + 1m 19s
     261 tests ±       0       261 ✔️ ±       0      0 💤 ±    0  0 ±0 
14 094 runs  +9 396  13 662 ✔️ +9 108  432 💤 +288  0 ±0 

Results for commit 9725ff9. ± Comparison against base commit d0787a9.

♻️ This comment has been updated with latest results.

@EnricoMi EnricoMi marked this pull request as ready for review February 24, 2022 19:35
@github-actions

This comment has been minimized.

@EnricoMi EnricoMi force-pushed the branch-fix-reset-timestamp-utc branch from 75d3494 to 9725ff9 Compare February 24, 2022 19:48
@github-actions
Copy link

Unit Test Results (setup-python)

       54 files  +     36         54 suites  +36   2m 27s ⏱️ + 1m 19s
     261 tests ±       0       261 ✔️ ±       0      0 💤 ±    0  0 ±0 
14 094 runs  +9 396  13 662 ✔️ +9 108  432 💤 +288  0 ±0 

Results for commit 9725ff9. ± Comparison against base commit d0787a9.

@EnricoMi EnricoMi merged commit b7c3873 into master Feb 24, 2022
@EnricoMi EnricoMi deleted the branch-fix-reset-timestamp-utc branch February 24, 2022 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The reset limit backoff code may not be timezone aware
1 participant