Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform get_pull to return full list of open PRs matching commit #244

Merged
merged 5 commits into from
Apr 3, 2022

Conversation

lachaib
Copy link
Contributor

@lachaib lachaib commented Apr 3, 2022

resolves #242

Copy link
Owner

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, this really looks like a great "first good issue". Only minor comments.

python/publish/publisher.py Show resolved Hide resolved
python/publish/publisher.py Outdated Show resolved Hide resolved
python/publish/publisher.py Outdated Show resolved Hide resolved
python/publish/publisher.py Outdated Show resolved Hide resolved
python/test/test_publisher.py Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Apr 3, 2022

Unit Test Results (reference)

       54 files  ±0         54 suites  ±0   2m 38s ⏱️ +13s
     267 tests ±0       267 ✔️ ±0      0 💤 ±0  0 ±0 
14 418 runs  ±0  13 986 ✔️ ±0  432 💤 ±0  0 ±0 

Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b.

This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
test_publisher.TestPublisher ‑ test_get_pull
test_publisher.TestPublisher ‑ test_get_pull_forked_repo
test_publisher.TestPublisher ‑ test_get_pull_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pull_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_no_search_results
test_publisher.TestPublisher ‑ test_get_pull_one_closed_matches
…
test_publisher.TestPublisher ‑ test_get_pulls
test_publisher.TestPublisher ‑ test_get_pulls_forked_repo
test_publisher.TestPublisher ‑ test_get_pulls_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pulls_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_no_search_results
test_publisher.TestPublisher ‑ test_get_pulls_one_closed_matches
…

♻️ This comment has been updated with latest results.

@EnricoMi
Copy link
Owner

EnricoMi commented Apr 3, 2022

I have simplified the "hiding comments" logging message and rework the logging in general, plus adjusted the tests.

@EnricoMi EnricoMi mentioned this pull request Apr 3, 2022
@github-actions
Copy link

github-actions bot commented Apr 3, 2022

Unit Test Results (setup-python)

       54 files  ±0         54 suites  ±0   2m 34s ⏱️ +9s
     267 tests ±0       267 ✔️ ±0      0 💤 ±0  0 ±0 
14 418 runs  ±0  13 986 ✔️ ±0  432 💤 ±0  0 ±0 

Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b.

This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
test_publisher.TestPublisher ‑ test_get_pull
test_publisher.TestPublisher ‑ test_get_pull_forked_repo
test_publisher.TestPublisher ‑ test_get_pull_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pull_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_no_search_results
test_publisher.TestPublisher ‑ test_get_pull_one_closed_matches
…
test_publisher.TestPublisher ‑ test_get_pulls
test_publisher.TestPublisher ‑ test_get_pulls_forked_repo
test_publisher.TestPublisher ‑ test_get_pulls_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pulls_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_no_search_results
test_publisher.TestPublisher ‑ test_get_pulls_one_closed_matches
…

@github-actions
Copy link

github-actions bot commented Apr 3, 2022

Unit Test Results (Linux)

       54 files  ±0         54 suites  ±0   2m 34s ⏱️ +9s
     267 tests ±0       267 ✔️ ±0      0 💤 ±0  0 ±0 
14 418 runs  ±0  13 986 ✔️ ±0  432 💤 ±0  0 ±0 

Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b.

This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
test_publisher.TestPublisher ‑ test_get_pull
test_publisher.TestPublisher ‑ test_get_pull_forked_repo
test_publisher.TestPublisher ‑ test_get_pull_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pull_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_no_search_results
test_publisher.TestPublisher ‑ test_get_pull_one_closed_matches
…
test_publisher.TestPublisher ‑ test_get_pulls
test_publisher.TestPublisher ‑ test_get_pulls_forked_repo
test_publisher.TestPublisher ‑ test_get_pulls_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pulls_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_no_search_results
test_publisher.TestPublisher ‑ test_get_pulls_one_closed_matches
…

@github-actions
Copy link

github-actions bot commented Apr 3, 2022

Unit Test Results (macOS)

       54 files  ±0         54 suites  ±0   2m 34s ⏱️ +9s
     267 tests ±0       267 ✔️ ±0      0 💤 ±0  0 ±0 
14 418 runs  ±0  13 986 ✔️ ±0  432 💤 ±0  0 ±0 

Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b.

This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
test_publisher.TestPublisher ‑ test_get_pull
test_publisher.TestPublisher ‑ test_get_pull_forked_repo
test_publisher.TestPublisher ‑ test_get_pull_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pull_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_no_search_results
test_publisher.TestPublisher ‑ test_get_pull_one_closed_matches
…
test_publisher.TestPublisher ‑ test_get_pulls
test_publisher.TestPublisher ‑ test_get_pulls_forked_repo
test_publisher.TestPublisher ‑ test_get_pulls_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pulls_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_no_search_results
test_publisher.TestPublisher ‑ test_get_pulls_one_closed_matches
…

@github-actions
Copy link

github-actions bot commented Apr 3, 2022

Unit Test Results (Windows)

       54 files  ±0         54 suites  ±0   2m 34s ⏱️ +9s
     267 tests ±0       267 ✔️ ±0      0 💤 ±0  0 ±0 
14 418 runs  ±0  13 986 ✔️ ±0  432 💤 ±0  0 ±0 

Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b.

This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
test_publisher.TestPublisher ‑ test_get_pull
test_publisher.TestPublisher ‑ test_get_pull_forked_repo
test_publisher.TestPublisher ‑ test_get_pull_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pull_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_no_search_results
test_publisher.TestPublisher ‑ test_get_pull_one_closed_matches
…
test_publisher.TestPublisher ‑ test_get_pulls
test_publisher.TestPublisher ‑ test_get_pulls_forked_repo
test_publisher.TestPublisher ‑ test_get_pulls_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pulls_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_no_search_results
test_publisher.TestPublisher ‑ test_get_pulls_one_closed_matches
…

@github-actions
Copy link

github-actions bot commented Apr 3, 2022

Unit Test Results (Test Files)

  25 files  ±0      4 errors  22 suites  ±0   39m 12s ⏱️ ±0s
272 tests ±0  227 ✔️ ±0  18 💤 ±0  23 ±0  4 🔥 ±0 
443 runs  ±0  357 ✔️ ±0  55 💤 ±0  26 ±0  5 🔥 ±0 

For more details on these parsing errors, failures and errors, see this check.

Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b.

@github-actions
Copy link

github-actions bot commented Apr 3, 2022

Unit Test Results (Dockerfile)

       54 files  ±0         54 suites  ±0   2m 34s ⏱️ +9s
     267 tests ±0       267 ✔️ ±0      0 💤 ±0  0 ±0 
14 418 runs  ±0  13 986 ✔️ ±0  432 💤 ±0  0 ±0 

Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b.

This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
test_publisher.TestPublisher ‑ test_get_pull
test_publisher.TestPublisher ‑ test_get_pull_forked_repo
test_publisher.TestPublisher ‑ test_get_pull_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pull_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_no_search_results
test_publisher.TestPublisher ‑ test_get_pull_one_closed_matches
…
test_publisher.TestPublisher ‑ test_get_pulls
test_publisher.TestPublisher ‑ test_get_pulls_forked_repo
test_publisher.TestPublisher ‑ test_get_pulls_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pulls_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_no_search_results
test_publisher.TestPublisher ‑ test_get_pulls_one_closed_matches
…

@github-actions
Copy link

github-actions bot commented Apr 3, 2022

Unit Test Results (Docker Image)

       54 files  ±0         54 suites  ±0   2m 34s ⏱️ +9s
     267 tests ±0       267 ✔️ ±0      0 💤 ±0  0 ±0 
14 418 runs  ±0  13 986 ✔️ ±0  432 💤 ±0  0 ±0 

Results for commit 4bcd0b4. ± Comparison against base commit 71bf14b.

This pull request removes 11 and adds 11 tests. Note that renamed tests count towards both.
test_publisher.TestPublisher ‑ test_get_pull
test_publisher.TestPublisher ‑ test_get_pull_forked_repo
test_publisher.TestPublisher ‑ test_get_pull_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pull_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pull_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pull_no_search_results
test_publisher.TestPublisher ‑ test_get_pull_one_closed_matches
…
test_publisher.TestPublisher ‑ test_get_pulls
test_publisher.TestPublisher ‑ test_get_pulls_forked_repo
test_publisher.TestPublisher ‑ test_get_pulls_forked_repos_and_own_repo
test_publisher.TestPublisher ‑ test_get_pulls_multiple_closed_matches
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_both_match_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_head_commit
test_publisher.TestPublisher ‑ test_get_pulls_multiple_open_one_matches_merge_commit
test_publisher.TestPublisher ‑ test_get_pulls_no_search_results
test_publisher.TestPublisher ‑ test_get_pulls_one_closed_matches
…

@EnricoMi
Copy link
Owner

EnricoMi commented Apr 3, 2022

@lachaib
Copy link
Contributor Author

lachaib commented Apr 3, 2022

Looks like everything is fine, I have no write access so I assume it's up to you to merge the PR, can you please notify me when the change gets released?
Thanks a lot for your precious time :)

@EnricoMi EnricoMi merged commit ae7c14a into EnricoMi:master Apr 3, 2022
@EnricoMi
Copy link
Owner

EnricoMi commented Apr 3, 2022

Thanks for the contribution!

@lachaib lachaib deleted the feature/242 branch April 4, 2022 07:47
@lachaib
Copy link
Contributor Author

lachaib commented Apr 4, 2022

Hi @EnricoMi , do you need to create a new release for this change to take effect? This morning the changes didn't take effect on our CI jobs.

@EnricoMi
Copy link
Owner

EnricoMi commented Apr 4, 2022

I'll release this in a few days.

@EnricoMi
Copy link
Owner

This has been released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support publishing to all open pull requests
2 participants