Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish results as job summary #266

Merged
merged 2 commits into from
May 12, 2022
Merged

Conversation

lachaib
Copy link
Contributor

@lachaib lachaib commented May 10, 2022

Fixes #264

I took the liberty of enhancing the tests to use absolute paths for files, it's easier to run tests in my IDE.

Copy link
Owner

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. A few minor comments but nothing controversial.

Can we move the test path related changes into a separate PR that we merge first? Just to keep that separated from the job summary code.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
action.yml Outdated Show resolved Hide resolved
action.yml Show resolved Hide resolved
python/publish/publisher.py Outdated Show resolved Hide resolved
python/publish/publisher.py Outdated Show resolved Hide resolved
python/publish/publisher.py Outdated Show resolved Hide resolved
python/publish/publisher.py Outdated Show resolved Hide resolved
python/test/test_publish.py Outdated Show resolved Hide resolved
python/test/test_action_yml.py Outdated Show resolved Hide resolved
@lachaib
Copy link
Contributor Author

lachaib commented May 10, 2022

Well, I think pretty much all comments have been covered 😌
Hope it's ok now 🤞

@lachaib lachaib requested a review from EnricoMi May 10, 2022 21:26
@EnricoMi
Copy link
Owner

PR #267 is merged, please rebase and I will review again tomorrow.

@github-actions
Copy link

github-actions bot commented May 10, 2022

Unit Test Results (reference)

       63 files  ±  0         63 suites  ±0   3m 3s ⏱️ ±0s
     273 tests +  1       273 ✔️ +  1      0 💤 ±0  0 ±0 
17 199 runs  +63  16 695 ✔️ +63  504 💤 ±0  0 ±0 

Results for commit b3bf870. ± Comparison against base commit b406f72.

♻️ This comment has been updated with latest results.

python/publish/publisher.py Outdated Show resolved Hide resolved
python/publish/publisher.py Outdated Show resolved Hide resolved
python/publish/publisher.py Outdated Show resolved Hide resolved
python/publish_unit_test_results.py Show resolved Hide resolved
python/test/test_publisher.py Outdated Show resolved Hide resolved
@EnricoMi EnricoMi mentioned this pull request May 11, 2022
@github-actions

This comment has been minimized.

@github-actions
Copy link

github-actions bot commented May 11, 2022

Unit Test Results (Linux python installed)

       63 files  ±  0         63 suites  ±0   3m 23s ⏱️ +20s
     273 tests +  1       273 ✔️ +  1      0 💤 ±0  0 ±0 
17 199 runs  +63  16 695 ✔️ +63  504 💤 ±0  0 ±0 

Results for commit e5bc065. ± Comparison against base commit b406f72.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 11, 2022

Unit Test Results (macOS python installed)

       63 files  ±  0         63 suites  ±0   3m 23s ⏱️ +20s
     273 tests +  1       273 ✔️ +  1      0 💤 ±0  0 ±0 
17 199 runs  +63  16 695 ✔️ +63  504 💤 ±0  0 ±0 

Results for commit e5bc065. ± Comparison against base commit b406f72.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 11, 2022

Unit Test Results (Test Files)

  26 files  ±0      4 errors  23 suites  ±0   39m 21s ⏱️ ±0s
279 tests ±0  228 ✔️ ±0  20 💤 ±0  25 ±0  6 🔥 ±0 
450 runs  ±0  358 ✔️ ±0  57 💤 ±0  28 ±0  7 🔥 ±0 

For more details on these parsing errors, failures and errors, see this check.

Results for commit e5bc065. ± Comparison against base commit b406f72.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 11, 2022

Unit Test Results (Dockerfile)

       63 files  ±  0         63 suites  ±0   3m 23s ⏱️ +20s
     273 tests +  1       273 ✔️ +  1      0 💤 ±0  0 ±0 
17 199 runs  +63  16 695 ✔️ +63  504 💤 ±0  0 ±0 

Results for commit e5bc065. ± Comparison against base commit b406f72.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

Unit Test Results (Docker Image)

       63 files  ±  0         63 suites  ±0   3m 12s ⏱️ +13s
     273 tests +  1       273 ✔️ +  1      0 💤 ±0  0 ±0 
17 199 runs  +63  16 695 ✔️ +63  504 💤 ±0  0 ±0 

Results for commit 9eac4d8. ± Comparison against base commit b406f72.

@github-actions
Copy link

github-actions bot commented May 11, 2022

Unit Test Results (macOS python 3.6)

       63 files  ±  0         63 suites  ±0   3m 23s ⏱️ +20s
     273 tests +  1       273 ✔️ +  1      0 💤 ±0  0 ±0 
17 199 runs  +63  16 695 ✔️ +63  504 💤 ±0  0 ±0 

Results for commit e5bc065. ± Comparison against base commit b406f72.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 11, 2022

Unit Test Results (Linux python 3.6)

       63 files  ±  0         63 suites  ±0   3m 23s ⏱️ +20s
     273 tests +  1       273 ✔️ +  1      0 💤 ±0  0 ±0 
17 199 runs  +63  16 695 ✔️ +63  504 💤 ±0  0 ±0 

Results for commit e5bc065. ± Comparison against base commit b406f72.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 11, 2022

Unit Test Results (Windows python installed)

       63 files  ±  0         63 suites  ±0   3m 23s ⏱️ +20s
     273 tests +  1       273 ✔️ +  1      0 💤 ±0  0 ±0 
17 199 runs  +63  16 695 ✔️ +63  504 💤 ±0  0 ±0 

Results for commit e5bc065. ± Comparison against base commit b406f72.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented May 11, 2022

Unit Test Results (Windows python 3.6)

       63 files  ±  0         63 suites  ±0   3m 23s ⏱️ +20s
     273 tests +  1       273 ✔️ +  1      0 💤 ±0  0 ±0 
17 199 runs  +63  16 695 ✔️ +63  504 💤 ±0  0 ±0 

Results for commit e5bc065. ± Comparison against base commit b406f72.

♻️ This comment has been updated with latest results.

@EnricoMi
Copy link
Owner

Look at this (scroll down to the job summaries): https://github.com/EnricoMi/publish-unit-test-result-action/actions/runs/2306018943

@EnricoMi
Copy link
Owner

What about this markdown for the job summary (reference comment and check)?

Currently:


4 parse errors, 6 errors, 25 fail, 20 skipped, 228 pass in 39m 21s

  26 files      4 errors  23 suites   39m 21s ⏱️
279 tests 228 ✔️ 20 💤 25  6 🔥
450 runs  358 ✔️ 57 💤 28  7 🔥

Results for commit 9eac4d8.


With title and one-line summary:


Unit Test Results (Test Files)

4 parse errors, 6 errors, 25 fail, 20 skipped, 228 pass in 39m 21s

  26 files      4 errors  23 suites   39m 21s ⏱️
279 tests 228 ✔️ 20 💤 25  6 🔥
450 runs  358 ✔️ 57 💤 28  7 🔥

Results for commit 9eac4d8.


Like the comment, not the check:


Unit Test Results (Test Files)

  26 files      4 errors  23 suites   39m 21s ⏱️
279 tests 228 ✔️ 20 💤 25  6 🔥
450 runs  358 ✔️ 57 💤 28  7 🔥

Results for commit 9eac4d8.

@lachaib
Copy link
Contributor Author

lachaib commented May 11, 2022

Which one do you prefer? I assume it's about not passing the title to get to the last one (my personal favorite)

@EnricoMi
Copy link
Owner

Yes, I prefer that one too.

python/publish_unit_test_results.py Outdated Show resolved Hide resolved
Copy link
Owner

@EnricoMi EnricoMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link

Unit Test Results (setup-python)

       63 files  ±  0         63 suites  ±0   3m 23s ⏱️ +20s
     273 tests +  1       273 ✔️ +  1      0 💤 ±0  0 ±0 
17 199 runs  +63  16 695 ✔️ +63  504 💤 ±0  0 ±0 

Results for commit e5bc065. ± Comparison against base commit b406f72.

@EnricoMi
Copy link
Owner

Thanks for the contribution!

@EnricoMi EnricoMi merged commit fbf7580 into EnricoMi:master May 12, 2022
@EnricoMi
Copy link
Owner

As those environment files are a GitHub Actions feature, I have added them to GithubAction class, including tests: #269

I am going to migrate publish_summary to it soon.

@EnricoMi
Copy link
Owner

This has been released, enjoy!

@EnricoMi EnricoMi mentioned this pull request May 17, 2022
@lachaib lachaib deleted the lachaib/issue264 branch June 21, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish results as job summary
2 participants