Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdist is missing tests #866

Open
mtelka opened this issue Nov 5, 2023 · 2 comments
Open

sdist is missing tests #866

mtelka opened this issue Nov 5, 2023 · 2 comments

Comments

@mtelka
Copy link
Contributor

mtelka commented Nov 5, 2023

The sdist package at PyPI is missing tests. Please add tests to sdist to make downstream testing easier. Thank you.

@mikewallace1979
Copy link
Contributor

Hi @mtelka - thanks for reporting the issue. Do you have a specific problem which is solved by the inclusion of the tests in the sdist?

We have no plan to add those for the moment and it is a change that is going to have a non-small impact in our distribution and testing pipeline.

@mtelka
Copy link
Contributor Author

mtelka commented Nov 6, 2023

I'm working on barman package update for OpenIndiana. During packaging we run tests to make sure everything is okay. If tests are included in sdist then the process is fully automatic. If we need to switch to github tarball to get tests then some manual work is needed. So not having tests in sdist is just an inconvenience for us.

The other issue with github tarballs is that they could change as time goes and this breaks build reproducibility so we always prefer to use sdists where possible.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants