Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove micro-optimizations for better minfiication #131

Open
LeaVerou opened this issue Mar 31, 2021 · 1 comment
Open

Remove micro-optimizations for better minfiication #131

LeaVerou opened this issue Mar 31, 2021 · 1 comment
Assignees

Comments

@LeaVerou
Copy link
Collaborator

Currently the code has a number of optimizations to minify better, which sometimes get in the way of readability, e.g. local single letter variables for true, overly long variable declarations with dozens of variables instead of separate ones and things like that.

These may have made sense in 2012 when jsep was first written, but in 2021, I think saving a few bytes at the expense of readability isn't worth it. Especially for a codebase as small as jsep, where the savings are not that huge anyway.

@EricSmekens are you ok with me refactoring these out slowly in the cases where readability would be improved?

@EricSmekens
Copy link
Owner

I completely agree. I think there are more optimizations possible when the code is more simple, so I fully agree on that fact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants