Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Routine maintenance is badly overdue #41

Open
ErinCall opened this issue Feb 9, 2019 · 0 comments
Open

Routine maintenance is badly overdue #41

ErinCall opened this issue Feb 9, 2019 · 0 comments

Comments

@ErinCall
Copy link
Owner

ErinCall commented Feb 9, 2019

I haven't touched this repo in almost 3 years 馃槶 let's get the tests passing on recent versions of the external dependencies (postgres, firefox, etc.)
ErinCall added a commit that referenced this issue Feb 10, 2019
@ErinCall
Make it possible to run the tests [#41]
af51af7 
`nosetests` fails, but only for some tests, and at least it runs!
`nosetests --exclude splinter` passes!

* upgrade psycopg to work with postgres 11.1
    * upgrade yoyo-migrations to work with the newer psycopg
        * update the yoyo command in the README and tests
* upgrade selenium to work with Firefox 65
    * upgrade splinter for the new selenium
    * upgrade requests for the new selenium
    * update the README to note the external `geckodriver` dependency
ErinCall added a commit that referenced this issue Feb 10, 2019
@ErinCall
Fix an upload-image test [#41]
f7771de 
Splinter no longer accepts invalid file paths for attach_file, so we
have to use a real one.
ErinCall added a commit that referenced this issue Feb 10, 2019
@ErinCall
Remove some outdated splinter hacks [#41]
ca4d338
ErinCall added a commit that referenced this issue Feb 10, 2019
@ErinCall
Fix add-image splinter tests [#41]
2055268 
* Use `type(keys.ENTER)` instead of `fill("\n")`, since the latter
    doesn't send an enter keypress any more
* Use time.sleep to make some race conditions less common
    * I hate this, but I haven't found a more reliable solution. I bet
    there's something somewhere in the code that deals with this
    properly, but heck if I can remember what it would look like or
    where to find it.
* Don't test tag-editing in the title-editing test
ErinCall added a commit that referenced this issue Feb 10, 2019
@ErinCall
Remove an old mlkshk reference [#41]
d31a1ea 
mlkshk is gone :( I guess it's time to accept it.
ErinCall added a commit that referenced this issue Feb 10, 2019
@ErinCall
Fix view-image splinter tests [#41]
123aea7 
* Use `type(keys.ENTER)` instead of `fill("\n")`, since the latter
    doesn't send an enter keypress any more
* Similarly, use `type(keys.TAB)` instead of fill("\t")`
* Use time.sleep to make a race condition less common
    * I hate this just as much as when I did it in edit-image
ErinCall added a commit that referenced this issue Feb 10, 2019
@ErinCall
Add @nottest decorators to some test helpers [#41]
206cf8a 
With this change, you can `nosetests web/splinter/` to run just the
splinter tests. Without it, nose tries to run the app middlewares and
routes as if they were tests. Shockingly, that doesn't work.
ErinCall added a commit that referenced this issue Feb 10, 2019
@ErinCall
Remove an obsolete workaround [#41]
3821742 
The requests library resolved that https connection problem at some
point in the last 3 years! Hurrah!
ErinCall added a commit that referenced this issue Feb 11, 2019
@ErinCall
Update bcrypt and sqlalchemy [#41]
c9b51b8 
At this point I'm just updating things to latest...
ErinCall added a commit that referenced this issue Feb 11, 2019
@ErinCall
Remove outdated argparse dependency [#41]
c604cac 
It was a holdover from when catsnap was a command-line utility rather
than a web service. It's no longer necessary
ErinCall added a commit that referenced this issue Feb 11, 2019
@ErinCall
Update gunicorn by 19 major versions :O [#41]
ca5d14c 
It...still seems to work fine? Either I'm setting myself up for a nasty
surprise or it's all been internal improvements.
ErinCall added a commit that referenced this issue Feb 11, 2019
@ErinCall
Update to the latest Wand [#41]
44ca6c7
ErinCall added a commit that referenced this issue Feb 11, 2019
@ErinCall
Revert "Update to the latest Wand [#41]"
780e874 
This reverts commit 44ca6c7.

Something is breaking wand's ability to load the imagemagick libraries,
but only when running under gunicorn on ubuntu. Maybe this will fix it?
ErinCall added a commit that referenced this issue Feb 11, 2019
@ErinCall
Revert "Update gunicorn by 19 major versions :O [#41]"
ae2139f 
This reverts commit ca5d14c.

It caused problems...or at least it may've
ErinCall added a commit that referenced this issue Feb 11, 2019
@ErinCall
Revert "Revert "Update to the latest Wand [#41]""
bd0efa6 
This reverts commit 780e874.

It did not fix the problem :(
ErinCall added a commit that referenced this issue Feb 11, 2019
@ErinCall
Revert "Update gunicorn by 19 major versions :O [#41]"
ca9e453 
This reverts commit ca5d14c.
ErinCall added a commit that referenced this issue Feb 11, 2019
@ErinCall
Merge pull request #45 from ErinCall/overdue-maintenance
57427b8 
Support recent versions of external dependencies #41
ErinCall added a commit to ErinCall/server-management that referenced this issue Feb 11, 2019
@ErinCall
Support the latest version of catsnap [ErinCall/catsnap#41]
a8612da
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ErinCall