Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for kebabified global attributes (enter-key-hint, input-mode) #9260

Open
1 of 5 tasks
jcfranco opened this issue May 3, 2024 · 0 comments
Open
1 of 5 tasks

Remove support for kebabified global attributes (enter-key-hint, input-mode) #9260

jcfranco opened this issue May 3, 2024 · 0 comments
Labels
0 - new New issues that need assignment. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.

Comments

@jcfranco
Copy link
Member

jcfranco commented May 3, 2024

Description

#9245 fixed a regression caused by refactoring components to use global attributes, where kebab-cased global attributes were unintentionally removed.

This should be removed in a major release to allow us to fully rely on global attributes.

Proposed Advantages

Removal of workaround.

Which Component

input, input-text and input-number.

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@jcfranco jcfranco added refactor Issues tied to code that needs to be significantly reworked. breaking change Issues and pull requests with code changes that are not backwards compatible. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 3, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. breaking change Issues and pull requests with code changes that are not backwards compatible. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcfranco