Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to mobile behaviour at 768px #148

Open
matthiasr81 opened this issue Feb 14, 2017 · 1 comment
Open

Switching to mobile behaviour at 768px #148

matthiasr81 opened this issue Feb 14, 2017 · 1 comment

Comments

@matthiasr81
Copy link

When using a calcite-maps app on my ipad, which device-width is 768px, the app behaves like on a mobile device (e.g. the panels are full screen). When i took a look on the calcite-maps.css-file, it seems, that switching to mobile behaviour happens, when the device-width is equal oder smaller than 768px

efor example:

@media ( min-width :769px) {
.visible-mobile-only {
display: none !important
}
}

In the calcite-maps.js on the other hand, there is a variable "isMobile", which is set to "true", if device-width is smaller than 768px.
It seems to me, that it is not exactly clear, what happens, when the device-with is exactly 768px. The treatment in css and javascript seems to be incosistent. In my opinion, in this case the app should use the non mobile behaviour, because i think it is for example not necessary that the panels open full screen on a tablet.

@alaframboise
Copy link
Contributor

@matthiasr81 thanks, I'll look into why I did this. I think there's a reason! ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants