-
-
Notifications
You must be signed in to change notification settings - Fork 956
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EssentialsXDiscord Addon] Discord<->MC Account Linker #4155
Conversation
One Idea:
Example: Me replying to you would result in Issues I see here now is, how or if there should be an indicator in the message syntax to show that the message was from Discord. |
To adress my previous comment do I have an idea for a possible Like here would be the full Idea again with the new suggestion added:
I hope this idea still makes sense to you |
Is that notif spam (*cough* @JRoy posting trollface *cough*) really necessary? I know I know, you do reviews and stuff, but did you consider people watching this PR for possible progress and don't want to have spam? |
ea34da4
to
f60355f
Compare
I'm sure this has been discussed... but since I've apparently been living under a rock, why is EssentialsDiscordLink a completely separate plugin from EssentialsDiscord? It seems to me like it would make much more sense to merge the two together. |
I agree, but on the other hand would I assume that it could be considered bloat having this feature implemented in the base Module. |
Yeah but EssentialsDiscord has already become more than just a simple chat bridge. Arguably if this is going to be its own module, the stuff for console relay, etc, should have as well. I don't really see the distinction here. Making people download yet another addon (for what is already an addon) makes little sense to me, and seems like something people are just gonna complain about. In terms of bloat, there's barely anything really added to the configuration by this. There's like 3 configuration options, which could just be its own little section in the main addon. Everything could be disabled by default, as with the console relay. |
Role sync is going to be a part of this as well, which I feel is fairly big. I'd like to keep these code bases separate to make it easier to maintain and to force myself to keep the addon API quality high. |
The EssentialsX Discord Link module is now feature complete and ready for review! cc @mdcfe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary skin review, more in-depth review will come later
Essentials/src/main/java/com/earth2me/essentials/perm/IPermissionsHandler.java
Show resolved
Hide resolved
EssentialsChat/src/main/java/com/earth2me/essentials/chat/EssentialsChat.java
Outdated
Show resolved
Hide resolved
...rd/src/main/java/net/essentialsx/api/v2/services/discord/InteractionCommandArgumentType.java
Show resolved
Hide resolved
EssentialsDiscordLink/src/main/java/net/essentialsx/discordlink/AccountStorage.java
Show resolved
Hide resolved
EssentialsDiscordLink/src/main/java/net/essentialsx/discordlink/AccountStorage.java
Outdated
Show resolved
Hide resolved
EssentialsDiscordLink/src/main/java/net/essentialsx/discordlink/EssentialsDiscordLink.java
Show resolved
Hide resolved
...tialsDiscordLink/src/main/java/net/essentialsx/discordlink/listeners/LinkBukkitListener.java
Show resolved
Hide resolved
If a member who's linked leaves the Discord server, an Unknown Member error appears upon role sync.
|
Thanks for the catch, fixed in the latest build! |
EssentialsChat/src/main/java/com/earth2me/essentials/chat/EssentialsChat.java
Outdated
Show resolved
Hide resolved
dc6d642
to
3654032
Compare
3654032
to
cb59dd6
Compare
[15:11:52 WARN]: [net.essentialsx.discordlink.EssentialsDiscordLink] Versiyon uyuşmazlığı! Lütfen tüm Essentials jarlarını aynı sürüme güncelleyin. Pufferfish 1.19.3 Not working |
A separate plugin/addon on top of EssentialsXDiscord to add linking functionality between discord and minecraft.
Tracking Ideas from https://github.com/orgs/EssentialsX/projects/1#card-57639460