Add separate events for local and global chat #4683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
brawaru
commented
Dec 12, 2021
Essentials/src/main/java/net/ess3/api/events/LocalChatSpyEvent.java
Outdated
Show resolved
Hide resolved
brawaru
force-pushed
the
feat/add-chat-type-events
branch
from
842e9fb
to
45a0678
Compare
triagonal
added
module: chat
brawaru
force-pushed
the
feat/add-chat-type-events
branch
from
45a0678
to
bc14df3
Compare
JRoy
requested changes
Mar 27, 2022
Essentials/src/main/java/net/ess3/api/events/LocalChatSpyEvent.java
Outdated
Show resolved
Hide resolved
...tialsChat/src/main/java/com/earth2me/essentials/chat/EssentialsChatPlayerListenerNormal.java
Outdated
Show resolved
Hide resolved
EssentialsChat/src/main/java/com/earth2me/essentials/chat/ChatStore.java
Outdated
Show resolved
Hide resolved
...tialsChat/src/main/java/com/earth2me/essentials/chat/EssentialsChatPlayerListenerNormal.java
Outdated
Show resolved
Hide resolved
brawaru
force-pushed
the
feat/add-chat-type-events
branch
from
18f24f7
to
f9e6f52
Compare
|
Hello and thanks for the review! Sorry it took some time, but all noted issues should be fixed now. |
brawaru
force-pushed
the
feat/add-chat-type-events
branch
from
f9e6f52
to
1bf775e
Compare
brawaru
force-pushed
the
feat/add-chat-type-events
branch
from
1bf775e
to
a0fc04c
Compare
JRoy
requested changes
Jul 5, 2022
Essentials/src/main/java/net/essentialsx/api/v2/events/ChatEvent.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/net/essentialsx/api/v2/events/GlobalChatEvent.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/net/essentialsx/api/v2/events/LocalChatEvent.java
Outdated
Show resolved
Hide resolved
brawaru
force-pushed
the
feat/add-chat-type-events
branch
from
21b8556
to
0cd4898
Compare
|
Rebased and moved new event classes to |
JRoy
previously approved these changes
Jul 6, 2022
|
Hey, apologies for the slow response on this. We recently refactored EssentialsX Chat, so this PR will need need to be updated this PR accordingly (ie moving the |
brawaru
force-pushed
the
feat/add-chat-type-events
branch
from
0cd4898
to
c162217
Compare
|
Heyo! I have rebased this on |
brawaru
commented
Aug 17, 2022
brawaru
commented
Aug 17, 2022
EssentialsChat/src/main/java/com/earth2me/essentials/chat/processing/AbstractChatHandler.java
Outdated
Show resolved
Hide resolved
brawaru
force-pushed
the
feat/add-chat-type-events
branch
2 times, most recently
from
8977e3f
to
3c60995
Compare
JRoy
requested changes
Aug 19, 2022
Essentials/src/main/java/net/essentialsx/api/v2/events/chat/ChatEvent.java
Outdated
Show resolved
Hide resolved
Essentials/src/main/java/net/essentialsx/api/v2/events/chat/LocalChatEvent.java
Show resolved
Hide resolved
This commit adds two new events: GlobalChatEvent and LocalChatEvent, which allow other plugin developers to know whether the message sent is a global or local one and act accordingly. If either of those events is cancelled, then the source event is cancelled too. Since all chat-related events share the same structure, a new abstract class ChatEvent is created with change made for LocalChatSpyEvent to use it without breaking its API.
brawaru
force-pushed
the
feat/add-chat-type-events
branch
from
3c60995
to
7bd890d
Compare
JRoy
approved these changes
Aug 22, 2022
mdcfe
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR helps DiscordSRV/DiscordSRV#1223.
Details
Proposed feature:
This PR adds two new events: GlobalChatEvent and LocalChatEvent, which allow other plugin developers to know whether the message sent is a global or local one and act accordingly. If either of those events is cancelled, then the source event is cancelled too.
Since all chat-related events share the same structure, a new abstract class ChatEvent is created with the change made for LocalChatSpyEvent to use it without breaking its API.
Environments tested:
OS: Windows 10 20H2.
Java version:
Demonstration:
Following this pull request, a draft pull request with the use of that API in Essentials Discord module was created — #4684.