Fix double charge for /tpa when target has /tpauto on #4862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdcfe
added
bug: confirmed
pop4959
approved these changes
Mar 19, 2022
PureGero
pushed a commit
to CritterzNFT/Essentials
that referenced
this pull request
Apr 20, 2022
If a player uses `/tpa` to request a teleport to someone with `/tpauto` enabled, `/tpa` manually creates a charge for the teleportation. This PR changes the subsequent code to throw a `NoChargeException` instead of returning, meaning only the `AsyncTeleport` charge is applied, not the standard command one. Fixes EssentialsX#4854.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Information
This PR fixes #4854.
Details
Proposed fix:
If a player uses
/tpato request a teleport to someone with/tpautoenabled,/tpamanually creates a charge for the teleportation.This PR changes the subsequent code to throw a
NoChargeExceptioninstead of returning, meaning only theAsyncTeleportcharge is applied, not the standard command one.Environments tested:
OS: Windows 11 22000.556
Java version: Eclipse Temurin 17.0.1+12
Demonstration: