Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix paths and farmland not being solid #4915

Merged
merged 3 commits into from
Jun 18, 2022
Merged

Fix paths and farmland not being solid #4915

merged 3 commits into from
Jun 18, 2022

Conversation

JRoy
Copy link
Member

@JRoy JRoy commented May 23, 2022

Fixes #4787

@JRoy JRoy added bug: confirmed Confirmed bugs in EssentialsX. module: main Issues or PRs for the main Essentials module labels May 23, 2022
@JRoy JRoy added this to the 2.19.5 milestone May 23, 2022
@JRoy JRoy added type: bugfix PRs that fix bugs in EssentialsX. and removed bug: confirmed Confirmed bugs in EssentialsX. labels May 23, 2022
pop4959
pop4959 approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@pop4959 pop4959 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for now, we should probably consider making a category for these in the future if there are more "transparent but solid" blocks (maybe TRANSPARENT_SOLID_TYPES).

@mdcfe mdcfe enabled auto-merge (squash) June 18, 2022 19:29
@mdcfe mdcfe merged commit 8d856dd into EssentialsX:2.x Jun 18, 2022
@JRoy JRoy deleted the fix/path-farmland-solid branch June 23, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdcfe mdcfe mdcfe approved these changes

@pop4959 pop4959 pop4959 approved these changes

Assignees
No one assigned
Labels
module: main Issues or PRs for the main Essentials module type: bugfix PRs that fix bugs in EssentialsX.
Projects
None yet
Milestone
2.19.5
Development

Successfully merging this pull request may close these issues.

/Sethome not working on Path block: Unsafe location
3 participants
@JRoy @mdcfe @pop4959